Details
Run comm app on web and check if space between buttons is clickable.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
It is usually a good idea for a parent to position their children instead of children positioning themselves. Concretely, we should prefer to set gap on flex container instead of setting margin on arbitrarily chosen component.
web/chat/thread-top-bar.css | ||
---|---|---|
52–63 ↗ | (On Diff #28433) | |
web/chat/thread-top-bar.react.js | ||
90 ↗ | (On Diff #28433) | This line will cause a new array to be created on every render, which may cause performance issues, so it's always better to avoid it. There are a couple of techniques which can be used to avoid the recomputation:
But none of these should be used here, because after introducing gap, this component will have only one class. |
Looks good! This diff is simple so it doesn't matter that much, but usually we're including a screenshot of the result in a test plan / summary.