[lib] Add hasMinStateVersion
ClosedPublic
Actions

Authored by michal on Jul 10 2023, 10:25 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM55ab3e7d65da: [lib] Add hasMinStateVersion

Summary

ENG-4350

Added so landing the id schema migration stack doesn't break dev env. Wasn't sure if it should be merged with hasMinCodeVersion but I can't imagine a scenario where we want to check both code version and state version, and it would complicate the logic a bit so I decided against it. But I'm open to changes.

Test Plan

Tested with the next diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Jul 10 2023, 10:25 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 10 2023, 10:25 AM

michal added a child revision: D8386: [lib] Enable new id schema.Jul 10 2023, 10:26 AM

Harbormaster completed remote builds in B20849: Diff 28557.Jul 10 2023, 10:42 AM

michal requested review of this revision.Jul 10 2023, 10:42 AM

kamil accepted this revision.Jul 11 2023, 2:10 AM

kamil added inline comments.

lib/shared/version-utils.js
39–59	wondering if there is an easy way to create a generic function and put shared logic there as `hasMinCodeVersion`, but probably this will make the code more complicated and less readable, so this also looks okay