Added so landing the id schema migration stack doesn't break dev env. Wasn't sure if it should be merged with hasMinCodeVersion but I can't imagine a scenario where we want to check both code version and state version, and it would complicate the logic a bit so I decided against it. But I'm open to changes.
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMM55ab3e7d65da: [lib] Add hasMinStateVersion
Tested with the next diff
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/shared/version-utils.js | ||
---|---|---|
39–59 ↗ | (On Diff #28557) | wondering if there is an easy way to create a generic function and put shared logic there as hasMinCodeVersion, but probably this will make the code more complicated and less readable, so this also looks okay |
lib/shared/version-utils.js | ||
---|---|---|
39–59 ↗ | (On Diff #28557) | I tried to generalise the code but it always made the logic more complicated so I don't think it's worth it. |