[keyserver] Exclude ETH accounts from username reservation system
ClosedPublic
Actions

Authored by varun on Jul 11 2023, 10:40 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM5aa3c5fca9da: [keyserver] Exclude ETH accounts from username reservation system

Summary

We should not add ETH addresses to the reserved usernames list on the identity service

Resolves https://linear.app/comm/issue/ENG-4335/make-sure-we-exclude-eth-accounts-from-username-reservation-system

Test Plan

ran the cronjob locally and saw that the ETH usernames in my users table weren't added to the DDB table

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jul 11 2023, 10:40 PM

Herald added a subscriber: tomek. · View Herald TranscriptJul 11 2023, 10:40 PM

varun added a child revision: D8482: Add code comments to make sure Rust <> JS "reserved usernames" are mirrored.Jul 11 2023, 10:55 PM

Harbormaster completed remote builds in B20886: Diff 28608.Jul 11 2023, 11:01 PM

varun requested review of this revision.Jul 11 2023, 11:01 PM

ashoat accepted this revision.Jul 12 2023, 5:45 AM

This revision is now accepted and ready to land.Jul 12 2023, 5:45 AM

Closed by commit rCOMM5aa3c5fca9da: [keyserver] Exclude ETH accounts from username reservation system (authored by varun). · Explain WhyJul 12 2023, 1:04 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM5aa3c5fca9da: [keyserver] Exclude ETH accounts from username reservation system.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

cron/

update-identity-reserved-usernames.js

6 lines

Diff 28640

View Options

keyserver/src/cron/update-identity-reserved-usernames.js

[keyserver] Exclude ETH accounts from username reservation systemClosedPublicActions