Add code comments to make sure Rust <> JS "reserved usernames" are mirrored
ClosedPublic
Actions

Authored by varun on Jul 11 2023, 10:55 PM.

Details

Reviewers

ashoat
• jon

Commits

rCOMM8aee89ab54fe: Add code comments to make sure Rust <> JS "reserved usernames" are mirrored

Summary

adding comments to help ensure the two lists stay in sync

Note that I could not add comments to the actual reserved_usernames.json file
since comments aren't allowed in JSON notation

Depends on D8481

Test Plan

N/A, just comments

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jul 11 2023, 10:55 PM

Herald added a reviewer: • jon. · View Herald TranscriptJul 11 2023, 10:55 PM

Herald added a subscriber: tomek. · View Herald Transcript

Harbormaster completed remote builds in B20888: Diff 28610.Jul 11 2023, 11:15 PM

varun requested review of this revision.Jul 11 2023, 11:15 PM

ashoat accepted this revision.Jul 12 2023, 5:46 AM

This revision is now accepted and ready to land.Jul 12 2023, 5:46 AM

Closed by commit rCOMM8aee89ab54fe: Add code comments to make sure Rust <> JS "reserved usernames" are mirrored (authored by varun). · Explain WhyJul 12 2023, 1:04 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM8aee89ab54fe: Add code comments to make sure Rust <> JS "reserved usernames" are mirrored.

Revision Contents
Changeset List

Path

Size

lib/

utils/

reserved-users.js

3 lines

services/

identity/

src/

config.rs

2 lines

Diff 28641

View Options

lib/utils/reserved-users.js