Page MenuHomePhabricator

[identity] helper functions for removing data from DDB
ClosedPublic

Authored by varun on Jul 14 2023, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Tue, Nov 5, 2:12 AM
Unknown Object (File)
Oct 13 2024, 12:09 AM
Unknown Object (File)
Oct 4 2024, 9:38 AM
Unknown Object (File)
Sep 21 2024, 6:37 PM
Unknown Object (File)
Sep 21 2024, 5:40 PM
Subscribers

Details

Summary

on logout, we need to delete/remove the access token and keys associated with the logged out device.

the first helper function removes the device's keys from the users table with an update expression.

the second helper function deletes the device's access token from the access tokens table by calling delete_item().

Test Plan

created test data in local DDB and called the helper functions from main to confirm that the keys and token were removed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2023, 1:01 PM
Harbormaster failed remote builds in B20935: Diff 28689!
varun requested review of this revision.Jul 14 2023, 1:02 PM

CI is failing because of a network issue. will retry the jobs later

This revision is now accepted and ready to land.Jul 14 2023, 3:11 PM
This revision was landed with ongoing or failed builds.Aug 14 2023, 11:58 AM
This revision was automatically updated to reflect the committed changes.

landed this with failures because none of the builds that failed have anything to do with the identity service