Page MenuHomePhabricator
Differential D8538

[Keyserver/rust] Initialize gRPC with host's TLS certs
ClosedPublic
Actions

Authored by • jon on Jul 18 2023, 2:18 PM.
Tags
None
Referenced Files
F3383987: D8538.diff
Thu, Nov 28, 6:48 PM
Unknown Object (File)
Mon, Nov 25, 2:57 PM
Unknown Object (File)
Tue, Nov 19, 5:45 AM
Unknown Object (File)
Tue, Nov 19, 5:45 AM
Unknown Object (File)
Tue, Nov 19, 5:45 AM
Unknown Object (File)
Tue, Nov 19, 5:44 AM
Unknown Object (File)
Tue, Nov 19, 5:39 AM
Unknown Object (File)
Sun, Nov 3, 1:54 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
ashoat
Commits
rCOMMd8a895c13a62: [Keyserver/rust] Initialize gRPC with host's TLS certs
Summary

Ensure that connections using https have the host's
CA certificates loaded prior to connecting to identity service.

https://linear.app/comm/issue/ENG-4410

Test Plan
  • Dev Workflow:
    • Start localstack and identity service
    • cd keyserver && yarn dev
  • Prod Workflow:
    • export COMM_JSONCONFIG_secrets_identity_service_config="{\"identitySocketAddr\":\"https://identity.commtechnologies.org:50054\"}"
    • cd keyserver && yarn dev

In both workflows, the metadata table should be populated
with user_id and access_token

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/fix-rust-node-addon-tls
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 18 2023, 2:18 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 18 2023, 2:18 PM
• jon edited the test plan for this revision. (Show Details)Jul 18 2023, 2:20 PM
• jon updated this revision to Diff 28801.Jul 18 2023, 2:36 PM

Add debian ca-cert path

Harbormaster completed remote builds in B21007: Diff 28798.Jul 18 2023, 2:54 PM
Harbormaster completed remote builds in B21008: Diff 28801.Jul 18 2023, 3:01 PM
• jon requested review of this revision.Jul 18 2023, 3:01 PM
bartek accepted this revision.Jul 19 2023, 4:46 AM
This revision is now accepted and ready to land.Jul 19 2023, 4:46 AM
varun accepted this revision.Jul 19 2023, 7:03 AM
• jon added a reviewer: ashoat.Jul 19 2023, 9:16 AM
This revision now requires review to proceed.Jul 19 2023, 9:16 AM
ashoat resigned from this revision.Jul 19 2023, 11:48 AM

No context on Rust

This revision is now accepted and ready to land.Jul 19 2023, 11:48 AM
Closed by commit rCOMMd8a895c13a62: [Keyserver/rust] Initialize gRPC with host's TLS certs (authored by • jon). · Explain WhyJul 19 2023, 2:18 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMd8a895c13a62: [Keyserver/rust] Initialize gRPC with host's TLS certs.
• jon mentioned this in D8577: [Docs] Document keyserver deployment.Jul 19 2023, 3:08 PM
varun mentioned this in rCOMM5e6f277fa1fb: [Docs] Document keyserver deployment.Aug 12 2023, 11:20 AM

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
2 lines
src/
identity_client/
53 lines

Diff 28798

View Options

keyserver/addons/rust-node-addon/Cargo.lock

Loading...
View Options

keyserver/addons/rust-node-addon/Cargo.toml

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...