Page MenuHomePhabricator
Differential D8647

[blob-service] Test HTTP Ranges
AbandonedPublic
Actions

Authored by • patryk on Jul 27 2023, 10:33 AM.
Tags
None
Referenced Files
F3384537: D8647.diff
Thu, Nov 28, 9:29 PM
Unknown Object (File)
Sat, Nov 23, 9:55 AM
Unknown Object (File)
Sat, Nov 23, 9:55 AM
Unknown Object (File)
Sat, Nov 23, 9:55 AM
Unknown Object (File)
Sat, Nov 23, 9:55 AM
Unknown Object (File)
Sat, Nov 23, 9:55 AM
Unknown Object (File)
Thu, Nov 21, 9:05 AM
Unknown Object (File)
Thu, Nov 21, 9:05 AM
View All 92 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
tomek
• jon
Summary

Solution for ENG-4437.
This diff adds additional HTTP Range tests to blob_integration_test.

Depends on D8643

Test Plan

In services/commtest run yarn run-integration-tests blob and check if there are no errors.

Diff Detail

Repository
rCOMM Comm
Branch
patryk/blob-integration-test
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Jul 27 2023, 10:33 AM
• patryk held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptJul 27 2023, 10:33 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
Harbormaster failed remote builds in B21279: Diff 29141!Jul 27 2023, 10:42 AM
• patryk updated this revision to Diff 29143.Jul 27 2023, 12:57 PM

Rebase

Harbormaster failed remote builds in B21281: Diff 29143!Jul 27 2023, 1:00 PM
• patryk edited the summary of this revision. (Show Details)Jul 27 2023, 1:05 PM
• patryk edited the test plan for this revision. (Show Details)
• patryk edited reviewers, added: bartek, tomek, michal; removed: • jon.
Herald added a reviewer: • jon. · View Herald TranscriptJul 27 2023, 1:05 PM
• patryk edited the summary of this revision. (Show Details)Jul 27 2023, 1:06 PM
• patryk added a parent revision: D8643: [blob-service] Clean up uploaded blob data if any test fails.
• patryk updated this revision to Diff 29146.Jul 27 2023, 1:15 PM
• patryk edited the test plan for this revision. (Show Details)

Rebase

• patryk published this revision for review.Jul 27 2023, 1:19 PM
• patryk removed a reviewer: michal.
Harbormaster failed remote builds in B21284: Diff 29146!Jul 27 2023, 1:53 PM
bartek accepted this revision.Jul 28 2023, 4:46 AM
This revision is now accepted and ready to land.Jul 28 2023, 4:46 AM
• patryk planned changes to this revision.Aug 4 2023, 3:20 AM

I'm planning to move HTTP Range test to a separate test.

• patryk abandoned this revision.Sep 13 2023, 9:00 AM

Unfortunately, I don't have time to fix this diff, so I'll have to abandon it because it requires a refactor.

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
blob/
3 lines
26 lines
1 line
tests/
89 lines
10 lines

Diff 29143

View Options

services/commtest/src/blob/constants.rs

Loading...
View Options

services/commtest/src/blob/get.rs

Loading...
View Options

services/commtest/src/blob/mod.rs

Loading...
View Options

services/commtest/tests/blob_integration_test.rs

Loading...
View Options

services/commtest/tests/blob_performance_test.rs

Loading...