This is no longer needed since user_id was previously needed to find the user in identity-users table, but the onetime keys tables only care about device id.

these should be in the previous diff

chose to combine one-time to onetime because this was the existing standard

for consistency

this is a bit awkward, but create_device_info takes the entire object.

This is a bit awkward, where we can't write the one time keys in the same call. However, refactoring the user write to be included in the batch_write will require us to remove all mentions of the expression-related logic (E.g. set_expression_attribute_names and set_expression_attribute_values).

But, overall, the code is reading as "If I successfully create this user, please add these onetime keys as well"; which I think is fine.

This clone probably isn't required

decided to create a new file, database.rs is already massive.

This is a bit repetitive, but WriteRequest also supports deletes, so seems to be the canonical way to describe "Create a WriteRequest which contains a put action".