[lib] Memoize array that gets passed to useThreadSearchIndex
ClosedPublic
Actions

Authored by ashoat on Aug 8 2023, 6:57 AM.

Details

Reviewers

atul
tomek
ginsu

Commits

rCOMM6257ce420776: [lib] Memoize array that gets passed to useThreadSearchIndex

Summary

This addresses ENG-4605 by fixing the regression that I introduced here.

Test Plan

I was able to repro the issue in my local environment by opening the SidebarListModal on my iOS simulator. After this diff, the issue no longer reproed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Aug 8 2023, 6:57 AM

Harbormaster completed remote builds in B21588: Diff 29617.Aug 8 2023, 7:16 AM

ashoat requested review of this revision.Aug 8 2023, 7:16 AM

tomek accepted this revision.Aug 8 2023, 7:36 AM

This revision is now accepted and ready to land.Aug 8 2023, 7:36 AM

Closed by commit rCOMM6257ce420776: [lib] Memoize array that gets passed to useThreadSearchIndex (authored by ashoat). · Explain WhyAug 8 2023, 7:51 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6257ce420776: [lib] Memoize array that gets passed to useThreadSearchIndex.

ashoat mentioned this in D9297: [lib] Fix memoization of useSearchSidebars.Sep 26 2023, 11:04 AM

ashoat mentioned this in rCOMM101eb34481de: [lib] Fix memoization of useSearchSidebars.Sep 26 2023, 11:29 AM

ashoat mentioned this in D10253: [web] Update AddUsersList to call useUserSearchIndex.Dec 11 2023, 9:38 AM

ashoat mentioned this in D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.Nov 7 2024, 5:13 AM

ashoat mentioned this in D14204: [native] fix avatars in directory.Jan 30 2025, 10:38 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

search-threads.js

6 lines

Diff 29620

View Options

lib/hooks/search-threads.js

	Show All 35 Lines
	import type { CommunityCreationMembersScreenParams } from '../community-creation/community-creation-members.react.js';			import type { CommunityCreationMembersScreenParams } from '../community-creation/community-creation-members.react.js';
	import type { ManagePublicLinkScreenParams } from '../invite-links/manage-public-link-screen.react.js';			import type { ManagePublicLinkScreenParams } from '../invite-links/manage-public-link-screen.react.js';
	import type { ViewInviteLinksScreenParams } from '../invite-links/view-invite-links-screen.react.js';			import type { ViewInviteLinksScreenParams } from '../invite-links/view-invite-links-screen.react.js';
	import type { ChatCameraModalParams } from '../media/chat-camera-modal.react.js';			import type { ChatCameraModalParams } from '../media/chat-camera-modal.react.js';
	import type { ImageModalParams } from '../media/image-modal.react.js';			import type { ImageModalParams } from '../media/image-modal.react.js';
	import type { ThreadAvatarCameraModalParams } from '../media/thread-avatar-camera-modal.react.js';			import type { ThreadAvatarCameraModalParams } from '../media/thread-avatar-camera-modal.react.js';
	import type { VideoPlaybackModalParams } from '../media/video-playback-modal.react.js';			import type { VideoPlaybackModalParams } from '../media/video-playback-modal.react.js';
	import type { CustomServerModalParams } from '../profile/custom-server-modal.react.js';			import type { CustomServerModalParams } from '../profile/custom-server-modal.react.js';
				import type { KeyserverSelectionBottomSheetParams } from '../profile/keyserver-selection-bottom-sheet.react.js';
	import type { UserRelationshipTooltipModalParams } from '../profile/user-relationship-tooltip-modal.react.js';			import type { UserRelationshipTooltipModalParams } from '../profile/user-relationship-tooltip-modal.react.js';
	import type { ChangeRolesScreenParams } from '../roles/change-roles-screen.react.js';			import type { ChangeRolesScreenParams } from '../roles/change-roles-screen.react.js';
	import type { CommunityRolesScreenParams } from '../roles/community-roles-screen.react.js';			import type { CommunityRolesScreenParams } from '../roles/community-roles-screen.react.js';
	import type { CreateRolesScreenParams } from '../roles/create-roles-screen.react.js';			import type { CreateRolesScreenParams } from '../roles/create-roles-screen.react.js';
	import type { MessageSearchParams } from '../search/message-search.react.js';			import type { MessageSearchParams } from '../search/message-search.react.js';
	import type { UserProfileAvatarModalParams } from '../user-profile/user-profile-avatar-modal.react.js';			import type { UserProfileAvatarModalParams } from '../user-profile/user-profile-avatar-modal.react.js';
	import type { UserProfileBottomSheetParams } from '../user-profile/user-profile-bottom-sheet.react.js';			import type { UserProfileBottomSheetParams } from '../user-profile/user-profile-bottom-sheet.react.js';

	▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines
	export const QRCodeSignInNavigatorRouteName = 'QRCodeSignInNavigator';			export const QRCodeSignInNavigatorRouteName = 'QRCodeSignInNavigator';
	export const QRCodeScreenRouteName = 'QRCodeScreen';			export const QRCodeScreenRouteName = 'QRCodeScreen';
	export const UserProfileBottomSheetNavigatorRouteName =			export const UserProfileBottomSheetNavigatorRouteName =
	'UserProfileBottomSheetNavigator';			'UserProfileBottomSheetNavigator';
	export const UserProfileBottomSheetRouteName = 'UserProfileBottomSheet';			export const UserProfileBottomSheetRouteName = 'UserProfileBottomSheet';
	export const UserProfileAvatarModalRouteName = 'UserProfileAvatarModal';			export const UserProfileAvatarModalRouteName = 'UserProfileAvatarModal';
	export const KeyserverSelectionListRouteName = 'KeyserverSelectionList';			export const KeyserverSelectionListRouteName = 'KeyserverSelectionList';
	export const AddKeyserverRouteName = 'AddKeyserver';			export const AddKeyserverRouteName = 'AddKeyserver';
				export const KeyserverSelectionBottomSheetRouteName =
				'KeyserverSelectionBottomSheet';

	export type RootParamList = {			export type RootParamList = {
	+LoggedOutModal: void,			+LoggedOutModal: void,
	+App: void,			+App: void,
	+ThreadPickerModal: ThreadPickerModalParams,			+ThreadPickerModal: ThreadPickerModalParams,
	+AddUsersModal: AddUsersModalParams,			+AddUsersModal: AddUsersModalParams,
	+CustomServerModal: CustomServerModalParams,			+CustomServerModal: CustomServerModalParams,
	+ColorSelectorModal: ColorSelectorModalParams,			+ColorSelectorModal: ColorSelectorModalParams,
	+ComposeSubchannelModal: ComposeSubchannelModalParams,			+ComposeSubchannelModal: ComposeSubchannelModalParams,
	+SidebarListModal: SidebarListModalParams,			+SidebarListModal: SidebarListModalParams,
	+ImagePasteModal: ImagePasteModalParams,			+ImagePasteModal: ImagePasteModalParams,
	+TermsAndPrivacyModal: TermsAndPrivacyModalParams,			+TermsAndPrivacyModal: TermsAndPrivacyModalParams,
	+SubchannelsListModal: SubchannelListModalParams,			+SubchannelsListModal: SubchannelListModalParams,
	+MessageReactionsModal: MessageReactionsModalParams,			+MessageReactionsModal: MessageReactionsModalParams,
	+Registration: void,			+Registration: void,
	+CommunityCreation: void,			+CommunityCreation: void,
	+InviteLinkModal: InviteLinkModalParams,			+InviteLinkModal: InviteLinkModalParams,
	+InviteLinkNavigator: void,			+InviteLinkNavigator: void,
	+RolesNavigator: void,			+RolesNavigator: void,
	+QRCodeSignInNavigator: void,			+QRCodeSignInNavigator: void,
	+UserProfileBottomSheetNavigator: void,			+UserProfileBottomSheetNavigator: void,
	+TunnelbrokerMenu: void,			+TunnelbrokerMenu: void,
				+KeyserverSelectionBottomSheet: KeyserverSelectionBottomSheetParams,
	};			};

	export type MessageTooltipRouteNames =			export type MessageTooltipRouteNames =
	\| typeof RobotextMessageTooltipModalRouteName			\| typeof RobotextMessageTooltipModalRouteName
	\| typeof MultimediaMessageTooltipModalRouteName			\| typeof MultimediaMessageTooltipModalRouteName
	\| typeof TextMessageTooltipModalRouteName;			\| typeof TextMessageTooltipModalRouteName;

	export const PinnableMessageTooltipRouteNames = [			export const PinnableMessageTooltipRouteNames = [
	▲ Show 20 Lines • Show All 161 Lines • Show Last 20 Lines

[lib] Memoize array that gets passed to useThreadSearchIndexClosedPublicActions