Paths

Table of Contentst

Differential D8762

[native] Show loading spinner during getOlmSessionInitializationData server call
ClosedPublic
Actions

Authored by ashoat on Aug 8 2023, 7:46 AM.

Tags

None

Referenced Files

	F2114578: D8762.diff
	Wed, Jun 26, 5:50 AM

	Unknown Object (File)
	Sat, Jun 15, 1:48 AM

	Unknown Object (File)
	Fri, Jun 14, 10:48 AM

	Unknown Object (File)
	Wed, Jun 12, 8:30 PM

	Unknown Object (File)
	Wed, Jun 12, 5:10 PM

	Unknown Object (File)
	Wed, Jun 12, 1:58 PM

	Unknown Object (File)
	Wed, Jun 5, 11:50 PM

	Unknown Object (File)
	Wed, Jun 5, 9:05 PM

View All 67 Files

Subscribers

Details

Reviewers

atul
marcin
ginsu

Commits

rCOMMfb2347e02d7e: [native] Show loading spinner during getOlmSessionInitializationData server call

Summary

This diff addresses ENG-4604.

Test Plan

Note that there is a bit of a stutter when the first loadingSelector finishes, since the second one doesn't overlap with the first. I decided that this was okay for now... we'll end up needing to change things here pretty soon anyways, since these keys will get fetched from the identity service instead of the keyserver in the near future.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Aug 8 2023, 7:46 AM

Herald added a subscriber: tomek. · View Herald TranscriptAug 8 2023, 7:46 AM

ashoat edited the test plan for this revision. (Show Details)Aug 8 2023, 7:47 AM

ashoat edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B21590: Diff 29619.Aug 8 2023, 8:04 AM

ashoat requested review of this revision.Aug 8 2023, 8:04 AM

ginsu accepted this revision.Aug 8 2023, 11:07 AM

This revision is now accepted and ready to land.Aug 8 2023, 11:07 AM

Closed by commit rCOMMfb2347e02d7e: [native] Show loading spinner during getOlmSessionInitializationData server call (authored by ashoat). · Explain WhyAug 8 2023, 11:34 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfb2347e02d7e: [native] Show loading spinner during getOlmSessionInitializationData server call.

Revision Contents
Changeset List

Path

Size

native/

account/

log-in-panel.react.js

25 lines

register-panel.react.js

25 lines

Diff 29635

native/account/log-in-panel.react.js

Loading...

native/account/register-panel.react.js

Loading...