[web] Hide reply tooltip button for multimedia
ClosedPublic
Actions

Authored by rohan on Aug 8 2023, 12:54 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMMab110b7eec6b: [web] Hide reply tooltip button for multimedia

Summary

Just took a second to change this, we don't want to check whether the message is composable since that includes both text and multimedia. Now, if the message is not text we will not show the tooltip icon.

Resolves https://linear.app/comm/issue/ENG-4520/reply-button-appears-for-images-on-web

Test Plan

See below and after to verify that the reply button no longer shows for multimedia

Before:

After:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Aug 8 2023, 12:54 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 8 2023, 12:54 PM

rohan edited the summary of this revision. (Show Details)Aug 8 2023, 12:55 PM

rohan edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B21659: Diff 29705.Aug 8 2023, 3:08 PM

rohan requested review of this revision.Aug 8 2023, 3:08 PM

atul accepted this revision.Aug 8 2023, 11:24 PM

atul added 1 blocking reviewer(s): ginsu.

rohan added a child revision: D8769: [native] Create a LinkedDevicesHeaderRightButton that will open the QR scanner.Aug 9 2023, 7:22 AM

rohan removed a child revision: D8769: [native] Create a LinkedDevicesHeaderRightButton that will open the QR scanner.Aug 9 2023, 7:28 AM

ginsu accepted this revision.Aug 9 2023, 9:06 AM

This revision is now accepted and ready to land.Aug 9 2023, 9:06 AM

Closed by commit rCOMMab110b7eec6b: [web] Hide reply tooltip button for multimedia (authored by rohan). · Explain WhyAug 9 2023, 9:39 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMab110b7eec6b: [web] Hide reply tooltip button for multimedia.

Revision Contents
Changeset List

Path

Size

web/

utils/

tooltip-action-utils.js

2 lines

Diff 29790

View Options

web/utils/tooltip-action-utils.js

[web] Hide reply tooltip button for multimediaClosedPublicActions