Page MenuHomePhabricator
Differential D8769

[native] Create a LinkedDevicesHeaderRightButton that will open the QR scanner
ClosedPublic
Actions

Authored by rohan on Aug 9 2023, 7:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 5:03 PM
Unknown Object (File)
Mon, Nov 25, 2:43 PM
Unknown Object (File)
Sun, Nov 24, 11:50 PM
Unknown Object (File)
Sat, Nov 23, 1:57 PM
Unknown Object (File)
Sat, Nov 23, 1:57 PM
Unknown Object (File)
Nov 17 2024, 8:21 AM
Unknown Object (File)
Oct 27 2024, 9:00 AM
Unknown Object (File)
Oct 23 2024, 5:38 AM
View All Files
Subscribers
ashoat

Details

Reviewers
atul
ginsu
varun
tomek
Commits
rCOMM98c4c9666714: [native] Create a LinkedDevicesHeaderRightButton that will open the QR scanner
Summary

We want to allow the react navigation header right button to be pressed in order to open the QR code scanner for the new login flow. The onPress action will come in a following diff, this just adds the header right component to the new LinkedDevices screen.

I know I could have inlined the headerRight component probably in profile.react.js, but since I plan to add some additional checks (i.e. if the device is on a simulator) when the header right is pressed before opening the QR code scanner, I thought it would be cleaner extracting it to its own component file.

Part of ENG-4476

Depends on D8764

Test Plan

Confirmed that the header right appears in the LinkedDevices screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Aug 9 2023, 7:22 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 9 2023, 7:22 AM
rohan edited the summary of this revision. (Show Details)Aug 9 2023, 7:22 AM
rohan edited the test plan for this revision. (Show Details)
rohan edited the summary of this revision. (Show Details)Aug 9 2023, 7:27 AM
rohan added a parent revision: D8764: [native] Add a 'linked devices' section on the app for primary devices.
rohan removed a parent revision: D8766: [web] Hide reply tooltip button for multimedia.
rohan updated this revision to Diff 29788.Aug 9 2023, 7:29 AM

Rebase

Harbormaster completed remote builds in B21672: Diff 29787.Aug 9 2023, 7:39 AM
Harbormaster completed remote builds in B21673: Diff 29788.Aug 9 2023, 7:48 AM
rohan requested review of this revision.Aug 9 2023, 7:48 AM
ginsu accepted this revision.Aug 9 2023, 9:08 AM
This revision is now accepted and ready to land.Aug 9 2023, 9:08 AM
rohan added a child revision: D8770: [native] Add the ExpoBarcodeScanner package.Aug 9 2023, 9:49 AM
Closed by commit rCOMM98c4c9666714: [native] Create a LinkedDevicesHeaderRightButton that will open the QR scanner (authored by rohan). · Explain WhyAug 14 2023, 7:57 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM98c4c9666714: [native] Create a LinkedDevicesHeaderRightButton that will open the QR scanner.

Revision Contents
Changeset List

Diff 29860

View Options

native/profile/linked-devices-header-right-button.react.js

Loading...
View Options

native/profile/profile.react.js

Loading...