Paths

Table of Contentst

-
web/
-
package.json
-
yarn.lock

Differential D8763

[web] Add qrcode.react dependency
ClosedPublic
Actions

Authored by rohan on Aug 8 2023, 11:20 AM.

Tags

None

Referenced Files

	F5858681: D8763.id.diff
	Wed, Apr 16, 2:26 PM

	Unknown Object (File)
	Wed, Apr 16, 11:27 AM

	Unknown Object (File)
	Wed, Apr 16, 6:53 AM

	Unknown Object (File)
	Tue, Apr 15, 6:23 AM

	Unknown Object (File)
	Tue, Apr 1, 6:44 PM

	Unknown Object (File)
	Sun, Mar 23, 8:57 AM

	Unknown Object (File)
	Mar 16 2025, 4:35 AM

	Unknown Object (File)
	Mar 6 2025, 3:47 PM

Subscribers

None

Details

Reviewers

atul
ginsu
tomek
varun
ashoat

Commits

rCOMM004ebff40808: [web] Add qrcode.react dependency

Summary

We'll use the qrcode.react package to generate QR codes on the web client for the new login flow.

The discussion for this dependency is on linear: https://linear.app/comm/issue/ENG-4474/research-packages-to-generate-qr-codes-on-secondary-devices

Test Plan

Ran yarn cleaninstall and made sure the component was able to be imported

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Aug 8 2023, 11:20 AM

rohan edited the summary of this revision. (Show Details)Aug 8 2023, 11:21 AM

rohan edited the test plan for this revision. (Show Details)

rohan added a child revision: D8764: [native] Add a 'linked devices' section on the app for primary devices.Aug 8 2023, 11:27 AM

rohan added 1 blocking reviewer(s): ashoat.Aug 8 2023, 11:29 AM

Harbormaster completed remote builds in B21594: Diff 29633.Aug 8 2023, 11:39 AM

rohan requested review of this revision.Aug 8 2023, 11:39 AM

ginsu accepted this revision.Aug 8 2023, 11:39 AM

ashoat accepted this revision.Aug 8 2023, 11:48 AM

This revision is now accepted and ready to land.Aug 8 2023, 11:48 AM

Closed by commit rCOMM004ebff40808: [web] Add qrcode.react dependency (authored by rohan). · Explain WhyAug 14 2023, 7:57 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM004ebff40808: [web] Add qrcode.react dependency.

Revision Contents
Changeset List

Path

Size

web/

1 line

5 lines

Diff 29858

web/package.json

	Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines		"dependencies": {
	"grpc-web": "^1.4.2",			"grpc-web": "^1.4.2",
	"history": "^4.6.3",			"history": "^4.6.3",
	"invariant": "^2.2.4",			"invariant": "^2.2.4",
	"is-svg": "^4.3.0",			"is-svg": "^4.3.0",
	"isomorphic-fetch": "^3.0.0",			"isomorphic-fetch": "^3.0.0",
	"lib": "0.0.1",			"lib": "0.0.1",
	"localforage": "^1.10.0",			"localforage": "^1.10.0",
	"lodash": "^4.17.21",			"lodash": "^4.17.21",
				"qrcode.react": "^3.1.0",
	"react": "18.1.0",			"react": "18.1.0",
	"react-circular-progressbar": "^2.0.2",			"react-circular-progressbar": "^2.0.2",
	"react-color": "^2.13.0",			"react-color": "^2.13.0",
	"react-dnd": "^11.1.3",			"react-dnd": "^11.1.3",
	"react-dnd-html5-backend": "^11.1.3",			"react-dnd-html5-backend": "^11.1.3",
	"react-dom": "18.1.0",			"react-dom": "18.1.0",
	"react-feather": "^2.0.3",			"react-feather": "^2.0.3",
	"react-icomoon": "^2.5.7",			"react-icomoon": "^2.5.7",
	Show All 39 Lines

yarn.lock

Loading...