Page MenuHomePhabricator
Differential D8806

[native] Prevent simulators from attempting to open the barcode scanner
ClosedPublic
Actions

Authored by rohan on Aug 14 2023, 8:50 AM.
Tags
None
Referenced Files
F5892949: D8806.id29864.diff
Thu, Apr 17, 8:42 AM
F5890978: D8806.id.diff
Thu, Apr 17, 6:53 AM
F5879650: D8806.id30042.diff
Thu, Apr 17, 1:58 AM
F5858967: D8806.id29923.diff
Wed, Apr 16, 3:01 PM
Unknown Object (File)
Wed, Apr 16, 1:49 AM
Unknown Object (File)
Tue, Apr 15, 6:23 AM
Unknown Object (File)
Thu, Mar 27, 2:52 AM
Unknown Object (File)
Mar 16 2025, 4:35 AM
View All 92 Files
Subscribers
ashoat

Details

Reviewers
atul
ginsu
tomek
varun
Commits
rCOMM2554810eaf0a: [native] Prevent simulators from attempting to open the barcode scanner
Summary

Launching the barcode scanner on a simulator crashes the entire app (this is because it is not a compatible platform.

We should prevent this from being accessed in the simulator.

Addresses ENG-4647

Depends on D8805

Test Plan

Confirmed that the scanner no longer is launched when on a simulator.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Aug 14 2023, 8:50 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 14 2023, 8:50 AM
rohan edited the summary of this revision. (Show Details)Aug 14 2023, 8:51 AM
rohan edited the test plan for this revision. (Show Details)
rohan added a parent revision: D8805: [native] Set up the BarCodeScanner to scan QR codes.
rohan retitled this revision from [native] Prevent emulators from attempting to open the barcode scanner to [native] Prevent simulators from attempting to open the barcode scanner.
Harbormaster completed remote builds in B21730: Diff 29864.Aug 14 2023, 9:07 AM
rohan requested review of this revision.Aug 14 2023, 9:07 AM
ginsu accepted this revision.Aug 14 2023, 9:16 AM
This revision is now accepted and ready to land.Aug 14 2023, 9:16 AM
rohan added a child revision: D8811: [web] Add a temporary login via QR code button on the log-in form.Aug 14 2023, 11:22 AM
ashoat added inline comments.Aug 15 2023, 11:56 AM
native/profile/linked-devices-header-right-button.react.js
27 ↗(On Diff #29864)

The whole navigation object doesn't need to be here. That object changes rather often; in contrast, the simple function navigate changes rarely. It would be much better to only pass in the navigate function

native/utils/url-utils.js
81 ↗(On Diff #29864)

Now that we're exporting this, I think it might be helpful to rename it to deviceIsEmulator... dev feels ambiguous (could refer to "dev mode")

rohan updated this revision to Diff 29923.Aug 15 2023, 12:08 PM

Address comments

Harbormaster completed remote builds in B21770: Diff 29923.Aug 15 2023, 12:27 PM
Closed by commit rCOMM2554810eaf0a: [native] Prevent simulators from attempting to open the barcode scanner (authored by rohan). · Explain WhyAug 17 2023, 12:50 PM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM2554810eaf0a: [native] Prevent simulators from attempting to open the barcode scanner.

Revision Contents
Changeset List

PathSize
native/
profile/
20 lines
utils/
5 lines

Diff 30042

View Options

native/profile/linked-devices-header-right-button.react.js

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines - [Debugging](./nix_web_workflows.md#debugging)
- [React Developer Tools](./nix_web_workflows.md#react-developer-tools) - [React Developer Tools](./nix_web_workflows.md#react-developer-tools)
- [Redux Developer Tools](./nix_web_workflows.md#redux-developer-tools) - [Redux Developer Tools](./nix_web_workflows.md#redux-developer-tools)
- [Debugging JavaScript](./nix_web_workflows.md#debugging-javascript) - [Debugging JavaScript](./nix_web_workflows.md#debugging-javascript)
- [Mobile workflows](./nix_mobile_workflows.md#mobile-workflows) - [Mobile workflows](./nix_mobile_workflows.md#mobile-workflows)
- [Running mobile app on iOS Simulator](./nix_mobile_workflows.md#running-mobile-app-on-ios-simulator) - [Running mobile app on iOS Simulator](./nix_mobile_workflows.md#running-mobile-app-on-ios-simulator)
- [Running mobile app on Android Emulator](./nix_mobile_workflows.md#running-mobile-app-on-android-emulator) - [Running mobile app on Android Emulator](./nix_mobile_workflows.md#running-mobile-app-on-android-emulator)
- [Running mobile app on physical iOS devices](./nix_mobile_workflows.md#running-mobile-app-on-physical-ios-devices) - [Running mobile app on physical iOS devices](./nix_mobile_workflows.md#running-mobile-app-on-physical-ios-devices)
- [Shared workflows](./nix_shared_workflows.md#shared-workflows) - [Shared workflows](./nix_shared_workflows.md#shared-workflows)
- [Inspect database with TablePlus](./nix_shared_workflows.md#inspect-database-with-tableplus)
- [Codegen](./nix_shared_workflows.md#codegen) - [Codegen](./nix_shared_workflows.md#codegen)
- [Codegen for JSI](./nix_shared_workflows.md#codegen-for-jsi) - [Codegen for JSI](./nix_shared_workflows.md#codegen-for-jsi)
- [Codegen for gRPC](./nix_shared_workflows.md#codegen-for-grpc) - [Codegen for gRPC](./nix_shared_workflows.md#codegen-for-grpc)
- [Working with Phabricator](./nix_shared_workflows.md#working-with-phabricator) - [Working with Phabricator](./nix_shared_workflows.md#working-with-phabricator)
- [Creating a new diff](./nix_shared_workflows.md#creating-a-new-diff) - [Creating a new diff](./nix_shared_workflows.md#creating-a-new-diff)
- [Updating a diff](./nix_shared_workflows.md#updating-a-diff) - [Updating a diff](./nix_shared_workflows.md#updating-a-diff)
- [Working with a stack](./nix_shared_workflows.md#working-with-a-stack) - [Working with a stack](./nix_shared_workflows.md#working-with-a-stack)
- [Committing a diff](./nix_shared_workflows.md#committing-a-diff) - [Committing a diff](./nix_shared_workflows.md#committing-a-diff)
- [Final notes](./nix_shared_workflows.md#final-notes) - [Final notes](./nix_shared_workflows.md#final-notes)
## How Nix introduces dependencies to a development environment ## How Nix introduces dependencies to a development environment
Nix installs packages in the Nix store at package-specific paths (e.g. `/nix/store/x7kdiasp...-clang/bin/clang`). When you run `nix develop`, Nix sets environment variables such as `PATH` to expose the binary dependencies to your shell. This model can be extended through shell hooks to support other build toolchains such as `pkg-config`, `cmake`, and many other language specific package managers by simply adding the respective toolchain to `nativeBuildInputs`. Nix installs packages in the Nix store at package-specific paths (e.g. `/nix/store/x7kdiasp...-clang/bin/clang`). When you run `nix develop`, Nix sets environment variables such as `PATH` to expose the binary dependencies to your shell. This model can be extended through shell hooks to support other build toolchains such as `pkg-config`, `cmake`, and many other language specific package managers by simply adding the respective toolchain to `nativeBuildInputs`.
View Options

native/utils/url-utils.js

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines - [Debugging](./nix_web_workflows.md#debugging)
- [React Developer Tools](./nix_web_workflows.md#react-developer-tools) - [React Developer Tools](./nix_web_workflows.md#react-developer-tools)
- [Redux Developer Tools](./nix_web_workflows.md#redux-developer-tools) - [Redux Developer Tools](./nix_web_workflows.md#redux-developer-tools)
- [Debugging JavaScript](./nix_web_workflows.md#debugging-javascript) - [Debugging JavaScript](./nix_web_workflows.md#debugging-javascript)
- [Mobile workflows](./nix_mobile_workflows.md#mobile-workflows) - [Mobile workflows](./nix_mobile_workflows.md#mobile-workflows)
- [Running mobile app on iOS Simulator](./nix_mobile_workflows.md#running-mobile-app-on-ios-simulator) - [Running mobile app on iOS Simulator](./nix_mobile_workflows.md#running-mobile-app-on-ios-simulator)
- [Running mobile app on Android Emulator](./nix_mobile_workflows.md#running-mobile-app-on-android-emulator) - [Running mobile app on Android Emulator](./nix_mobile_workflows.md#running-mobile-app-on-android-emulator)
- [Running mobile app on physical iOS devices](./nix_mobile_workflows.md#running-mobile-app-on-physical-ios-devices) - [Running mobile app on physical iOS devices](./nix_mobile_workflows.md#running-mobile-app-on-physical-ios-devices)
- [Shared workflows](./nix_shared_workflows.md#shared-workflows) - [Shared workflows](./nix_shared_workflows.md#shared-workflows)
- [Inspect database with TablePlus](./nix_shared_workflows.md#inspect-database-with-tableplus)
- [Codegen](./nix_shared_workflows.md#codegen) - [Codegen](./nix_shared_workflows.md#codegen)
- [Codegen for JSI](./nix_shared_workflows.md#codegen-for-jsi) - [Codegen for JSI](./nix_shared_workflows.md#codegen-for-jsi)
- [Codegen for gRPC](./nix_shared_workflows.md#codegen-for-grpc) - [Codegen for gRPC](./nix_shared_workflows.md#codegen-for-grpc)
- [Working with Phabricator](./nix_shared_workflows.md#working-with-phabricator) - [Working with Phabricator](./nix_shared_workflows.md#working-with-phabricator)
- [Creating a new diff](./nix_shared_workflows.md#creating-a-new-diff) - [Creating a new diff](./nix_shared_workflows.md#creating-a-new-diff)
- [Updating a diff](./nix_shared_workflows.md#updating-a-diff) - [Updating a diff](./nix_shared_workflows.md#updating-a-diff)
- [Working with a stack](./nix_shared_workflows.md#working-with-a-stack) - [Working with a stack](./nix_shared_workflows.md#working-with-a-stack)
- [Committing a diff](./nix_shared_workflows.md#committing-a-diff) - [Committing a diff](./nix_shared_workflows.md#committing-a-diff)
- [Final notes](./nix_shared_workflows.md#final-notes) - [Final notes](./nix_shared_workflows.md#final-notes)
## How Nix introduces dependencies to a development environment ## How Nix introduces dependencies to a development environment
Nix installs packages in the Nix store at package-specific paths (e.g. `/nix/store/x7kdiasp...-clang/bin/clang`). When you run `nix develop`, Nix sets environment variables such as `PATH` to expose the binary dependencies to your shell. This model can be extended through shell hooks to support other build toolchains such as `pkg-config`, `cmake`, and many other language specific package managers by simply adding the respective toolchain to `nativeBuildInputs`. Nix installs packages in the Nix store at package-specific paths (e.g. `/nix/store/x7kdiasp...-clang/bin/clang`). When you run `nix develop`, Nix sets environment variables such as `PATH` to expose the binary dependencies to your shell. This model can be extended through shell hooks to support other build toolchains such as `pkg-config`, `cmake`, and many other language specific package managers by simply adding the respective toolchain to `nativeBuildInputs`.