[native] Prevent simulators from attempting to open the barcode scanner
ClosedPublic
Actions

Authored by rohan on Aug 14 2023, 8:50 AM.

Details

Reviewers

atul
ginsu
tomek
varun

Commits

rCOMM2554810eaf0a: [native] Prevent simulators from attempting to open the barcode scanner

Summary

Launching the barcode scanner on a simulator crashes the entire app (this is because it is not a compatible platform.

We should prevent this from being accessed in the simulator.

Addresses ENG-4647

Depends on D8805

Test Plan

Confirmed that the scanner no longer is launched when on a simulator.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Aug 14 2023, 8:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 14 2023, 8:50 AM

rohan edited the summary of this revision. (Show Details)Aug 14 2023, 8:51 AM

rohan edited the test plan for this revision. (Show Details)

rohan added a parent revision: D8805: [native] Set up the BarCodeScanner to scan QR codes.

rohan retitled this revision from [native] Prevent emulators from attempting to open the barcode scanner to [native] Prevent simulators from attempting to open the barcode scanner.

Harbormaster completed remote builds in B21730: Diff 29864.Aug 14 2023, 9:07 AM

rohan requested review of this revision.Aug 14 2023, 9:07 AM

ginsu accepted this revision.Aug 14 2023, 9:16 AM

This revision is now accepted and ready to land.Aug 14 2023, 9:16 AM

rohan added a child revision: D8811: [web] Add a temporary login via QR code button on the log-in form.Aug 14 2023, 11:22 AM

ashoat added inline comments.Aug 15 2023, 11:56 AM

native/profile/linked-devices-header-right-button.react.js
27 ↗	(On Diff #29864)	The whole `navigation` object doesn't need to be here. That object changes rather often; in contrast, the simple function `navigate` changes rarely. It would be much better to only pass in the `navigate` function
native/utils/url-utils.js
81 ↗	(On Diff #29864)	Now that we're exporting this, I think it might be helpful to rename it to `deviceIsEmulator`... `dev` feels ambiguous (could refer to "dev mode")