Page MenuHomePhabricator

[native] Add a temporary sign in via QR code button on native
ClosedPublic

Authored by rohan on Aug 18 2023, 11:23 AM.
Tags
None
Referenced Files
F2087903: D8870.id30282.diff
Sun, Jun 23, 4:03 PM
F2087902: D8870.id30280.diff
Sun, Jun 23, 4:03 PM
F2087901: D8870.id30089.diff
Sun, Jun 23, 4:03 PM
F2087868: D8870.id.diff
Sun, Jun 23, 4:02 PM
F2087847: D8870.diff
Sun, Jun 23, 3:54 PM
F2081894: D8870.diff
Sat, Jun 22, 11:26 PM
Unknown Object (File)
Fri, Jun 21, 2:22 AM
Unknown Object (File)
Thu, Jun 20, 10:53 PM
Subscribers

Details

Summary

While we're still using the traditional form to log in on native, I'm hiding the QR code login flow behind a new login button (similar to what's done with the register (new) button). This is only
shown in development. The next diff will implement the screen that appears when clicking it.

I followed an approach similar to D7495

Addresses ENG-4649

Depends on D8836

Test Plan

Confirmed that the button appears only in development (only touched the sign in buttons, left register buttons as-is)

__DEV__!__DEV__
Simulator Screen Shot - iPhone 14 Pro - 2023-08-18 at 14.20.52.png (2×1 px, 1 MB)
Simulator Screen Shot - iPhone 14 Pro - 2023-08-18 at 14.23.46.png (2×1 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan edited the test plan for this revision. (Show Details)

Confused how the second screenshot shows a Register (new) but NOT a Sign in (QR). Based on the code, shouldn't they show up in the exact same scenarios?

Confused how the second screenshot shows a Register (new) but NOT a Sign in (QR). Based on the code, shouldn't they show up in the exact same scenarios?

I probably could've clarified better. When I said "Confirmed that the button appears only in development (only touched the sign in buttons, left register buttons as-is)", I meant I only toggled the __DEV__ check for the sign-in buttons conditional, and left the register buttons conditional as-is.

Here's what toggling both if (__DEV__) checks to if (!__DEV__) looks like:

Simulator Screen Shot - iPhone 14 Pro - 2023-08-21 at 10.18.12.png (2×1 px, 1 MB)

One inline comment, but LGTM!

native/account/logged-out-modal.react.js
561 ↗(On Diff #30089)

Nit: I would prefer a more specific/clear key name for this maybe login-form

This revision is now accepted and ready to land.Aug 24 2023, 9:21 AM
This revision was landed with ongoing or failed builds.Aug 24 2023, 10:05 AM
This revision was automatically updated to reflect the committed changes.