Page MenuHomePhabricator
Differential D7495

[native] Add second register button only visible to devs
ClosedPublic
Actions

Authored by ashoat on Apr 18 2023, 11:23 AM.
Tags
None
Referenced Files
F2137150: D7495.id25294.diff
Fri, Jun 28, 4:55 PM
Unknown Object (File)
Thu, Jun 27, 8:20 AM
Unknown Object (File)
Sun, Jun 23, 4:03 PM
Unknown Object (File)
Sun, Jun 23, 4:03 PM
Unknown Object (File)
Sun, Jun 23, 4:03 PM
Unknown Object (File)
Sun, Jun 23, 4:02 PM
Unknown Object (File)
Sun, Jun 23, 3:53 PM
Unknown Object (File)
Sun, Jun 23, 5:29 AM
View All 67 Files
Subscribers
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMM94fac674b4fe: [native] Add second register button only visible to devs
Summary

The second register button currently does the same thing that the old one does, but in the next diffs I'll start to differentiate it.

Depends on D7494

Test Plan
beforeafter (__DEV__)after (!__DEV__)
Screenshot 2023-04-18 at 2.21.17 PM.png (1×521 px, 294 KB)
Screenshot 2023-04-18 at 2.21.21 PM.png (1×521 px, 295 KB)
Screenshot 2023-04-18 at 2.21.36 PM.png (1×521 px, 293 KB)

("before" and "after (!__DEV__)" should look identical)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 18 2023, 11:23 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 18 2023, 11:23 AM
ashoat edited the test plan for this revision. (Show Details)Apr 18 2023, 11:24 AM
Harbormaster completed remote builds in B18467: Diff 25293.Apr 18 2023, 11:41 AM
ashoat requested review of this revision.Apr 18 2023, 11:41 AM
ashoat updated this revision to Diff 25294.Apr 18 2023, 11:41 AM

Add React keys

ashoat added a child revision: D7496: [native] Add empty RegistrationNavigator & KeyserverSelection.Apr 18 2023, 11:45 AM
Harbormaster completed remote builds in B18468: Diff 25294.Apr 18 2023, 11:59 AM
ginsu accepted this revision.Apr 18 2023, 1:44 PM
This revision is now accepted and ready to land.Apr 18 2023, 1:44 PM
Closed by commit rCOMM94fac674b4fe: [native] Add second register button only visible to devs (authored by ashoat). · Explain WhyApr 19 2023, 6:39 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM94fac674b4fe: [native] Add second register button only visible to devs.
rohan mentioned this in D8870: [native] Add a temporary sign in via QR code button on native.Aug 18 2023, 11:23 AM
rohan mentioned this in rCOMM76fbf968845d: [native] Add a temporary sign in via QR code button on native.Aug 24 2023, 10:05 AM

Revision Contents
Changeset List

PathSize
native/
account/
43 lines

Diff 25440

View Options

native/account/logged-out-modal.react.js

Loading...