Page MenuHomePhabricator

[native] Add empty RegistrationNavigator & KeyserverSelection
ClosedPublic

Authored by ashoat on Apr 18 2023, 11:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 4:03 PM
Unknown Object (File)
Sun, Jun 23, 4:03 PM
Unknown Object (File)
Sun, Jun 23, 4:03 PM
Unknown Object (File)
Sun, Jun 23, 4:03 PM
Unknown Object (File)
Sun, Jun 23, 4:02 PM
Unknown Object (File)
Sun, Jun 23, 3:53 PM
Unknown Object (File)
Sun, Jun 16, 3:03 PM
Unknown Object (File)
Sat, Jun 15, 2:03 PM
Subscribers

Details

Summary

This diff adds the plumbing for RegistrationNavigator and KeyserverSelection, and makes the new registration button open it.

Depends on D7495

Test Plan
recording

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/account/registration-modal.react.js
12 ↗(On Diff #25295)

Flow complains if I remove the props param, and ESLint complains if I leave it in unused

Realized we need a separate StackNavigator for registration

ashoat retitled this revision from [native] Add empty RegistrationModal to [native] Add empty RegistrationNavigator & KeyserverSelection.Apr 18 2023, 12:18 PM
ashoat edited the summary of this revision. (Show Details)
ashoat edited the test plan for this revision. (Show Details)

Clean up, fix styles, remove KeyboardAvoidingView.

Sorry for the repeated iterations here; should be ready for review now.

native/account/registration/keyserver-selection.react.js
14 ↗(On Diff #25300)

Flow complains if I remove the props param, and ESLint complains if I leave it in unused

native/account/registration/registration-navigator.react.js
33 ↗(On Diff #25300)

Flow complains if I remove the props param, and ESLint complains if I leave it in unused

This revision is now accepted and ready to land.Apr 19 2023, 9:40 AM