[native] Introduce RegistrationContainer
ClosedPublic
Actions

Authored by ashoat on Apr 18 2023, 1:05 PM.

Tags

None

Referenced Files

	F2150449: D7501.id25443.diff
	Sun, Jun 30, 10:17 AM

	Unknown Object (File)
	Wed, Jun 26, 5:26 PM

	Unknown Object (File)
	Mon, Jun 24, 7:02 AM

	Unknown Object (File)
	Sun, Jun 23, 4:03 PM

	Unknown Object (File)
	Sun, Jun 23, 4:03 PM

	Unknown Object (File)
	Sun, Jun 23, 4:02 PM

	Unknown Object (File)
	Sun, Jun 23, 3:53 PM

	Unknown Object (File)
	May 19 2024, 3:04 AM

View All 53 Files

Subscribers

tomek

Details

Reviewers

ginsu
atul

Commits

rCOMM22ef9dfc868b: [native] Introduce RegistrationContainer

Summary

Factoring out the container and header height logic so it can be reused in other screens. More context in the preceding diff.

Depends on D7500

Test Plan

Everything still works the same as before. Also Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 18 2023, 1:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 18 2023, 1:05 PM

Harbormaster completed remote builds in B18476: Diff 25302.Apr 18 2023, 1:23 PM

ashoat requested review of this revision.Apr 18 2023, 1:23 PM

atul accepted this revision.Apr 19 2023, 9:44 AM

This revision is now accepted and ready to land.Apr 19 2023, 9:44 AM

Closed by commit rCOMM22ef9dfc868b: [native] Introduce RegistrationContainer (authored by ashoat). · Explain WhyApr 19 2023, 6:39 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM22ef9dfc868b: [native] Introduce RegistrationContainer.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

keyserver-selection.react.js

21 lines

registration-container.react.js

33 lines

Diff 25443

View Options

native/account/registration/keyserver-selection.react.js