[native] Add the ExpoBarcodeScanner package
ClosedPublic
Actions

Authored by rohan on Aug 9 2023, 9:49 AM.

Details

Reviewers

atul
ginsu
tomek
varun
ashoat

Commits

rCOMM22d3ec784069: [native] Add the ExpoBarcodeScanner package

Summary

This will allow us to use the BarCodeScanner component on native to scan the QR codes on secondary devices.

Depends on D8769

Test Plan

Ran yarn cleaninstall and pod install after running the install command (expo install expo-barcode-scanner) and confirmed I could import the component.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Aug 9 2023, 9:49 AM

Harbormaster completed remote builds in B21674: Diff 29791.Aug 9 2023, 10:07 AM

rohan requested review of this revision.Aug 9 2023, 10:07 AM

rohan edited the test plan for this revision. (Show Details)Aug 9 2023, 10:10 AM

Does this package version work with the version of Expo that we're running? (Sometimes we have to use older versions)

This revision is now accepted and ready to land.Aug 9 2023, 10:20 AM

In D8770#258995, @ashoat wrote:

Does this package version work with the version of Expo that we're running? (Sometimes we have to use older versions)

It should be fine, I've been able to use the BarCodeScanner component on my physical device with no problem while testing

rohan added a child revision: D8771: [native] Create Flow ExpoBarcodeScanner libdef.Aug 9 2023, 11:22 AM

Closed by commit rCOMM22d3ec784069: [native] Add the ExpoBarcodeScanner package (authored by rohan). · Explain WhyAug 14 2023, 7:57 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM22d3ec784069: [native] Add the ExpoBarcodeScanner package.