Page MenuHomePhabricator
Differential D8785

[landing] address keybase comparison touch ups
ClosedPublic
Actions

Authored by ginsu on Aug 10 2023, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 5:12 PM
Unknown Object (File)
Mon, Dec 30, 5:12 PM
Unknown Object (File)
Mon, Dec 30, 5:12 PM
Unknown Object (File)
Mon, Dec 30, 5:01 PM
Unknown Object (File)
Mon, Dec 30, 4:17 PM
Unknown Object (File)
Thu, Dec 26, 12:50 PM
Unknown Object (File)
Sun, Dec 22, 12:42 PM
Unknown Object (File)
Nov 23 2024, 1:59 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
ashoat
Commits
rCOMM59b87f19c2f2: [landing] address keybase comparison touch ups
Summary

resolves the following keybase comparison copy:

https://linear.app/comm/issue/ENG-4624/keybase-comparison

Depends on D8784

Test Plan

Please see the screenshots:

Screenshot 2023-08-10 at 6.32.46 PM.png (944×1 px, 175 KB)

Screenshot 2023-08-10 at 6.33.34 PM.png (1×1 px, 190 KB)

Screenshot 2023-08-10 at 6.34.53 PM.png (1×1 px, 157 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 10 2023, 3:25 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 10 2023, 3:25 PM
ginsu edited the summary of this revision. (Show Details)Aug 10 2023, 3:38 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8784: [landing] address signal comparison copy touch ups.
ginsu attached a referenced file: F684625: Screenshot 2023-08-10 at 6.34.53 PM.png. (Show Details)
ginsu attached a referenced file: F684624: Screenshot 2023-08-10 at 6.33.34 PM.png. (Show Details)
ginsu attached a referenced file: F684623: Screenshot 2023-08-10 at 6.32.46 PM.png. (Show Details)
ginsu added a child revision: D8788: [landing] address telegram comparison touch ups.Aug 10 2023, 3:42 PM
Harbormaster completed remote builds in B21703: Diff 29828.Aug 10 2023, 3:44 PM
ginsu requested review of this revision.Aug 10 2023, 3:44 PM
ashoat accepted this revision.Aug 11 2023, 5:31 AM
This revision is now accepted and ready to land.Aug 11 2023, 5:31 AM
ginsu updated this revision to Diff 29888.Aug 15 2023, 7:26 AM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 15 2023, 7:30 AM
Closed by commit rCOMM59b87f19c2f2: [landing] address keybase comparison touch ups (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM59b87f19c2f2: [landing] address keybase comparison touch ups.
Harbormaster completed remote builds in B21749: Diff 29888.Aug 15 2023, 7:44 AM

Revision Contents
Changeset List

PathSize
landing/
8 lines

Diff 29897

View Options

landing/competitor-data.js

Loading...