i noticed some incorrect patterns in our code using cargo clippy. in particular, we should use ok_or_else instead of ok_or when we're calling a function (lazy evaluation), avoid referencing when the compiler will immediately dereference anyway, and use Box to wrap large enum variants.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
services/identity/src/client_service.rs | ||
---|---|---|
49–50 ↗ | (On Diff #29931) | Just curious: Didn't Clippy also notice the fat type in the database Error type for AwsSdk? |
services/identity/src/client_service.rs | ||
---|---|---|
49–50 ↗ | (On Diff #29931) | hmm no it didn't. strange |