Paths

Table of Contentst

Differential D8825

[identity] helper functions to interact with nonces table
ClosedPublic
Actions

Authored by varun on Aug 15 2023, 8:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 2:31 AM

	Unknown Object (File)
	Fri, Nov 22, 10:50 PM

	Unknown Object (File)
	Thu, Nov 21, 7:38 AM

	Unknown Object (File)
	Thu, Nov 21, 7:38 AM

	Unknown Object (File)
	Thu, Nov 21, 7:38 AM

	Unknown Object (File)
	Thu, Nov 21, 7:37 AM

	Unknown Object (File)
	Sun, Nov 3, 5:26 PM

	Unknown Object (File)
	Oct 26 2024, 10:11 AM

View All 73 Files

Subscribers

Details

Reviewers

• jon
bartek

Commits

rCOMMcaa2afbd43be: [identity] helper functions to interact with nonces table

Summary

we need to be able to get and remove nonces from the nonces table.

Test Plan

added a nonce to the nonces table. then inspected it with the get method and deleted it with the remove method.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 15 2023, 8:49 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 8:49 PM

Harbormaster completed remote builds in B21778: Diff 29932.Aug 15 2023, 9:07 PM

varun requested review of this revision.Aug 15 2023, 9:07 PM

varun added a child revision: D8830: [identity] add ttl to nonces tables.Aug 16 2023, 12:20 AM

bartek accepted this revision.Aug 16 2023, 5:26 AM

bartek added inline comments.

services/identity/src/database.rs
829 ↗	(On Diff #29932)	Nit: I consider `impl Into<String>` a bit more flexible ;) Up to you
835 ↗	(On Diff #29932)	This is regarding above nit
840–843 ↗	(On Diff #29932)	Nit - we can do it this way too

This revision is now accepted and ready to land.Aug 16 2023, 5:26 AM

Closed by commit rCOMMcaa2afbd43be: [identity] helper functions to interact with nonces table (authored by varun). · Explain WhyAug 16 2023, 1:39 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMcaa2afbd43be: [identity] helper functions to interact with nonces table.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

55 lines

2 lines

Diff 29980

services/identity/src/database.rs

Loading...

services/identity/src/error.rs

Loading...