Page MenuHomePhabricator
Differential D8850

[blob][feature-flags] Replace deprecated methods
ClosedPublic
Actions

Authored by bartek on Aug 17 2023, 9:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 4:10 AM
Unknown Object (File)
Mon, Mar 17, 12:07 AM
Unknown Object (File)
Mar 4 2025, 2:27 PM
Unknown Object (File)
Mar 4 2025, 2:27 PM
Unknown Object (File)
Mar 4 2025, 2:26 PM
Unknown Object (File)
Mar 4 2025, 2:18 PM
Unknown Object (File)
Feb 15 2025, 10:46 AM
Unknown Object (File)
Feb 15 2025, 10:46 AM
View All 73 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• jon
Commits
rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods
Summary

In D8789 new methods were introduced for database attribute parsing. This diff replaces the deprecated methods with the new ones.

Test Plan

Cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 17 2023, 9:08 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 9:08 AM
Harbormaster completed remote builds in B21846: Diff 30019.Aug 17 2023, 9:25 AM
bartek published this revision for review.Aug 17 2023, 11:55 PM
bartek added inline comments.
services/blob/src/database/old.rs
1

The gRPC service is about to be deleted so I haven't bothered myself with updating this file

services/blob/src/service.rs
214

Unrelated, just a Clippy warn fix

michal accepted this revision.Aug 18 2023, 9:35 AM
This revision is now accepted and ready to land.Aug 18 2023, 9:35 AM
Closed by commit rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods (authored by bartek). · Explain WhyAug 22 2023, 12:17 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
database/
4 lines
2 lines
42 lines
2 lines
comm-services-lib/
src/
24 lines
feature-flags/
src/
16 lines

Diff 30019

View Options

services/blob/src/database/client.rs

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override; jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override; jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
void clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

services/blob/src/database/old.rs

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override; jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override; jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
void clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

services/blob/src/database/types.rs

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override; jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override; jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
void clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

services/blob/src/service.rs

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override; jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override; jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
void clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

services/comm-services-lib/src/database.rs

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override; jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override; jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
void clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

services/feature-flags/src/database.rs

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override; jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override; jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
void clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm