Page MenuHomePhabricator
Differential D8850

[blob][feature-flags] Replace deprecated methods
ClosedPublic
Actions

Authored by bartek on Aug 17 2023, 9:08 AM.
Tags
None
Referenced Files
F3231696: D8850.diff
Tue, Nov 12, 12:01 PM
Unknown Object (File)
Sun, Oct 27, 3:42 PM
Unknown Object (File)
Sep 27 2024, 11:38 PM
Unknown Object (File)
Sep 27 2024, 10:27 PM
Unknown Object (File)
Sep 27 2024, 10:27 PM
Unknown Object (File)
Sep 27 2024, 10:26 PM
Unknown Object (File)
Sep 27 2024, 10:19 PM
Unknown Object (File)
Sep 21 2024, 11:40 AM
View All 52 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• jon
Commits
rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods
Summary

In D8789 new methods were introduced for database attribute parsing. This diff replaces the deprecated methods with the new ones.

Test Plan

Cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 17 2023, 9:08 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 9:08 AM
Harbormaster completed remote builds in B21846: Diff 30019.Aug 17 2023, 9:25 AM
bartek published this revision for review.Aug 17 2023, 11:55 PM
bartek added inline comments.
services/blob/src/database/old.rs
1

The gRPC service is about to be deleted so I haven't bothered myself with updating this file

services/blob/src/service.rs
214

Unrelated, just a Clippy warn fix

michal accepted this revision.Aug 18 2023, 9:35 AM
This revision is now accepted and ready to land.Aug 18 2023, 9:35 AM
Closed by commit rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods (authored by bartek). · Explain WhyAug 22 2023, 12:17 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
database/
4 lines
2 lines
42 lines
2 lines
comm-services-lib/
src/
24 lines
feature-flags/
src/
16 lines

Diff 30019

View Options

services/blob/src/database/client.rs

Loading...
View Options

services/blob/src/database/old.rs

Loading...
View Options

services/blob/src/database/types.rs

Loading...
View Options

services/blob/src/service.rs

Loading...
View Options

services/comm-services-lib/src/database.rs

Loading...
View Options

services/feature-flags/src/database.rs

Loading...