[blob][feature-flags] Replace deprecated methods
ClosedPublic
Actions

Authored by bartek on Aug 17 2023, 4:08 PM.

Details

Reviewers

michal
• jon

Commits

rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods

Summary

In D8789 new methods were introduced for database attribute parsing. This diff replaces the deprecated methods with the new ones.

Test Plan

Cargo build

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 17 2023, 4:08 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 4:08 PM

Harbormaster completed remote builds in B21846: Diff 30019.Aug 17 2023, 4:25 PM

bartek published this revision for review.Aug 18 2023, 6:55 AM

bartek added inline comments.

services/blob/src/database/old.rs
1	The gRPC service is about to be deleted so I haven't bothered myself with updating this file
services/blob/src/service.rs
214	Unrelated, just a Clippy warn fix

michal accepted this revision.Aug 18 2023, 4:35 PM

This revision is now accepted and ready to land.Aug 18 2023, 4:35 PM

Closed by commit rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods. · Explain WhyAug 22 2023, 7:17 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM76f6c0d8990f: [blob][feature-flags] Replace deprecated methods.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database/

4 lines

2 lines

42 lines

2 lines

comm-services-lib/

src/

database.rs

24 lines

feature-flags/

src/

database.rs

16 lines

Diff 30019

View Options

services/blob/src/database/client.rs

View Options

services/blob/src/database/old.rs

View Options

services/blob/src/database/types.rs

View Options

services/blob/src/service.rs

View Options

services/comm-services-lib/src/database.rs

View Options

services/feature-flags/src/database.rs

[blob][feature-flags] Replace deprecated methodsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30019

services/blob/src/database/client.rs

services/blob/src/database/old.rs

services/blob/src/database/types.rs

services/blob/src/service.rs

services/comm-services-lib/src/database.rs

services/feature-flags/src/database.rs

[blob][feature-flags] Replace deprecated methods
ClosedPublic
Actions

Revision Contents
Changeset List