Page MenuHomePhabricator

[native/web] change title of MessageReactionsModal to All reactions
ClosedPublic

Authored by ginsu on Aug 17 2023, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 4:04 AM
Unknown Object (File)
Mon, Oct 28, 1:28 PM
Unknown Object (File)
Mon, Oct 28, 1:27 PM
Unknown Object (File)
Mon, Oct 28, 1:27 PM
Unknown Object (File)
Mon, Oct 28, 1:27 PM
Unknown Object (File)
Mon, Oct 28, 1:23 PM
Unknown Object (File)
Oct 4 2024, 7:02 AM
Unknown Object (File)
Sep 26 2024, 1:02 PM
Subscribers

Details

Summary

I am wrapping up the inline engagement redesign work right now, but didn't have the chance to work on redesigning the MessageReactionsModal. With the new inline engagement going to our old MessageReactionsModal felt a little jarring since the modal provides all the reactions to you and not just the reaction specific ones.

To make it a little less jarring I changed the title from "Reactions" to "All reactions" and I am hoping that this will make it more clear to the user that we are not showing the list of users for that specific reactions.

https://linear.app/comm/issue/ENG-3787/implement-a-redesign-for-message-reactions-modal is the task for this, and I am hoping to get to it whenever I have a free cycle

Test Plan

Please see screenshots

native:

Screenshot 2023-08-17 at 10.12.38 PM.png (1×1 px, 678 KB)

web:

Screenshot 2023-08-17 at 10.12.33 PM.png (2×3 px, 1018 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.Aug 17 2023, 7:30 PM
This revision is now accepted and ready to land.Aug 24 2023, 2:41 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing