use previously implemented helpers to implement the actual RPC method
Note that this intentionally does not include one-time keys (not required for inbound, only outbound).
Depends on D8765
Details
Details
called the RPC for an existing user in my local DDB table and got back required keys.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- getInboundKeysForUser (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/identity/src/client_service.rs | ||
|---|---|---|
| 826–834 ↗ | (On Diff #30060) | We should probably do something like .filter_map (|r| r.map_err(|e| error!("{}", e)).ok()).collect() to just collect the valid results. As written, I think if any of the InboundKeyInfo::try_from calls fail, it will make the entire query fail. |
| services/identity/src/client_service.rs | ||
|---|---|---|
| 828–836 ↗ | (On Diff #30159) | I think we want filter_map to remove all the Err's, and so we would only get back a HashMap. Would need to do some testing to verify though. If this doesn't yield results, I would just continue as-is. |
| services/identity/src/client_service.rs | ||
|---|---|---|
| 828–836 ↗ | (On Diff #30159) | kept the match statement but addressed your overall point about filtering out the Errs |