Page MenuHomePhabricator

[services-lib][blob-client] Revoke holder after upload failure
ClosedPublic

Authored by bartek on Aug 23 2023, 7:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 4:05 AM
Unknown Object (File)
Tue, Oct 22, 1:01 PM
Unknown Object (File)
Tue, Oct 22, 1:01 PM
Unknown Object (File)
Tue, Oct 22, 1:01 PM
Unknown Object (File)
Tue, Oct 22, 1:00 PM
Unknown Object (File)
Tue, Oct 22, 5:04 AM
Unknown Object (File)
Oct 4 2024, 3:45 PM
Unknown Object (File)
Sep 20 2024, 7:16 AM
Subscribers

Details

Summary

Our upload process is two-step. If the second step fails, we should revert the first step.
We want to revoke the holder (revert 1st step) after a failure to upload a blob (2nd step).

Test Plan

Artifically failed upload. Ensured that holder isn't there.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal added inline comments.
services/comm-services-lib/src/blob/client.rs
309 ↗(On Diff #30259)

Nit :P

This revision is now accepted and ready to land.Aug 23 2023, 10:48 PM

Fix typo, rebase on master, fix cargo dependencies