Page MenuHomePhabricator
Differential D8928

[services-lib][blob-client] Revoke holder after upload failure
ClosedPublic
Actions

Authored by bartek on Aug 23 2023, 7:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 11:41 PM
Unknown Object (File)
Sat, Jun 29, 10:47 PM
Unknown Object (File)
Thu, Jun 27, 4:02 AM
Unknown Object (File)
Tue, Jun 25, 8:53 AM
Unknown Object (File)
Tue, Jun 25, 8:53 AM
Unknown Object (File)
Tue, Jun 25, 8:53 AM
Unknown Object (File)
Tue, Jun 25, 8:53 AM
Unknown Object (File)
Tue, Jun 25, 8:52 AM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• jon
Commits
rCOMMb45ea600e802: [services-lib][blob-client] Revoke holder after upload failure
Summary

Our upload process is two-step. If the second step fails, we should revert the first step.
We want to revoke the holder (revert 1st step) after a failure to upload a blob (2nd step).

Test Plan

Artifically failed upload. Ensured that holder isn't there.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Aug 23 2023, 7:49 AM
Herald added a reviewer: • jon. · View Herald TranscriptAug 23 2023, 7:49 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B22043: Diff 30259.Aug 23 2023, 8:07 AM
bartek requested review of this revision.Aug 23 2023, 8:07 AM
michal accepted this revision.Aug 23 2023, 10:48 PM
michal added inline comments.
services/comm-services-lib/src/blob/client.rs
309 ↗(On Diff #30259)

Nit :P

This revision is now accepted and ready to land.Aug 23 2023, 10:48 PM
bartek updated this revision to Diff 30276.Aug 23 2023, 11:24 PM

Fix typo, rebase on master, fix cargo dependencies

Harbormaster completed remote builds in B22056: Diff 30276.Aug 23 2023, 11:43 PM
Closed by commit rCOMMb45ea600e802: [services-lib][blob-client] Revoke holder after upload failure (authored by bartek). · Explain WhyAug 23 2023, 11:51 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMb45ea600e802: [services-lib][blob-client] Revoke holder after upload failure.

Revision Contents
Changeset List

PathSize
services/
comm-services-lib/
2 lines
src/
blob/
26 lines

Diff 30277

View Options

services/comm-services-lib/Cargo.lock

Loading...
View Options

services/comm-services-lib/Cargo.toml

Loading...
View Options

services/comm-services-lib/src/blob/client.rs

Loading...