[services-lib][blob-client] Revoke holder after upload failure
ClosedPublic
Actions

Authored by bartek on Aug 23 2023, 7:49 AM.

Details

Reviewers

michal
• jon

Commits

rCOMMb45ea600e802: [services-lib][blob-client] Revoke holder after upload failure

Summary

Our upload process is two-step. If the second step fails, we should revert the first step.
We want to revoke the holder (revert 1st step) after a failure to upload a blob (2nd step).

Test Plan

Artifically failed upload. Ensured that holder isn't there.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 23 2023, 7:49 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 23 2023, 7:49 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B22043: Diff 30259.Aug 23 2023, 8:07 AM

bartek requested review of this revision.Aug 23 2023, 8:07 AM

michal accepted this revision.Aug 23 2023, 10:48 PM

michal added inline comments.

services/comm-services-lib/src/blob/client.rs
309	Nit :P

This revision is now accepted and ready to land.Aug 23 2023, 10:48 PM

Fix typo, rebase on master, fix cargo dependencies

Harbormaster completed remote builds in B22056: Diff 30276.Aug 23 2023, 11:43 PM

Closed by commit rCOMMb45ea600e802: [services-lib][blob-client] Revoke holder after upload failure (authored by bartek). · Explain WhyAug 23 2023, 11:51 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb45ea600e802: [services-lib][blob-client] Revoke holder after upload failure.

Revision Contents
Changeset List

Path

Size

services/

comm-services-lib/

src/

blob/

client.rs

26 lines

Diff 30259

View Options

services/comm-services-lib/src/blob/client.rs

[services-lib][blob-client] Revoke holder after upload failureClosedPublicActions