Page MenuHomePhabricator
Differential D9012

[lib] improve blob service facts
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 8:42 AM.
Tags
None
Referenced Files
F4957235: D9012.diff
Sat, Mar 22, 2:48 PM
Unknown Object (File)
Sun, Mar 16, 11:46 PM
Unknown Object (File)
Thu, Mar 6, 9:33 AM
Unknown Object (File)
Thu, Mar 6, 9:33 AM
Unknown Object (File)
Thu, Mar 6, 9:33 AM
Unknown Object (File)
Thu, Mar 6, 9:28 AM
Unknown Object (File)
Jan 11 2025, 6:48 PM
Unknown Object (File)
Jan 6 2025, 2:13 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
marcin
bartek
Commits
rCOMM6ad2e220bbb7: [lib] improve blob service facts
Summary

Context in https://phab.comm.dev/D8991#inline-57473

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
facts/
4 lines

Diff 30591

View Options

lib/facts/blob-service.js

// @flow // @flow
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
sendReactionMessage, sendReactionMessage,
sendReactionMessageActionTypes, sendReactionMessageActionTypes,
} from 'lib/actions/message-actions'; } from 'lib/actions/message-actions';
import { useModalContext } from 'lib/components/modal-provider.react'; import { useModalContext } from 'lib/components/modal-provider.react';
import { messageTypes } from 'lib/types/message-types';
import type { RawReactionMessageInfo } from 'lib/types/messages/reaction';
import { import {
useDispatchActionPromise, useDispatchActionPromise,
useServerCall, useServerCall,
} from 'lib/utils/action-utils'; } from 'lib/utils/action-utils';
import Alert from '../modals/alert.react'; import Alert from '../modals/alert.react';
import { useSelector } from '../redux/redux-utils';
function useOnClickReact( function useOnClickReact(
messageID: ?string, messageID: ?string,
localID: string, localID: string,
threadID: string, threadID: string,
reaction: string, reaction: string,
action: 'add_reaction' | 'remove_reaction', action: 'add_reaction' | 'remove_reaction',
): (event: SyntheticEvent<HTMLElement>) => mixed { ): (event: SyntheticEvent<HTMLElement>) => mixed {
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
const viewerID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,
);
const callSendReactionMessage = useServerCall(sendReactionMessage); const callSendReactionMessage = useServerCall(sendReactionMessage);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
return React.useCallback( return React.useCallback(
(event: SyntheticEvent<HTMLElement>) => { (event: SyntheticEvent<HTMLElement>) => {
event.preventDefault(); event.preventDefault();
if (!messageID) { if (!messageID) {
return; return;
} }
invariant(viewerID, 'viewerID should be set');
const reactionMessagePromise = (async () => { const reactionMessagePromise = (async () => {
try { try {
const result = await callSendReactionMessage({ const result = await callSendReactionMessage({
threadID, threadID,
localID, localID,
targetMessageID: messageID, targetMessageID: messageID,
reaction, reaction,
action, action,
Show All 9 Lines (event: SyntheticEvent<HTMLElement>) => {
<Alert title="Couldn’t send the reaction"> <Alert title="Couldn’t send the reaction">
Please try again later Please try again later
</Alert>, </Alert>,
); );
throw e; throw e;
} }
})(); })();
const startingPayload: RawReactionMessageInfo = {
type: messageTypes.REACTION,
threadID,
localID,
creatorID: viewerID,
time: Date.now(),
targetMessageID: messageID,
reaction,
action,
};
dispatchActionPromise( dispatchActionPromise(
sendReactionMessageActionTypes, sendReactionMessageActionTypes,
reactionMessagePromise, reactionMessagePromise,
undefined,
startingPayload,
); );
}, },
[ [
action,
callSendReactionMessage,
dispatchActionPromise,
messageID, messageID,
pushModal,
reaction,
threadID, threadID,
localID, localID,
viewerID,
reaction,
action,
dispatchActionPromise,
callSendReactionMessage,
pushModal,
], ],
); );
} }
export { useOnClickReact }; export { useOnClickReact };