Page MenuHomePhabricator

[native] clean up profile UI for users with long usernames
ClosedPublic

Authored by ginsu on Aug 29 2023, 10:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 19, 4:31 AM
Unknown Object (File)
Sun, May 19, 4:31 AM
Unknown Object (File)
Sun, May 19, 4:31 AM
Unknown Object (File)
Sun, May 19, 4:31 AM
Unknown Object (File)
Sun, May 19, 4:31 AM
Unknown Object (File)
Sun, May 19, 4:27 AM
Unknown Object (File)
Apr 3 2024, 11:22 PM
Unknown Object (File)
Apr 3 2024, 11:22 PM
Subscribers

Details

Summary

As I was working, I encountered a situation where users with long usernames had a profile that was not correctly aligned/styled

Here are the designs for reference:

Screenshot 2023-08-29 at 1.13.01 PM.png (1×620 px, 109 KB)

Test Plan

Please see screenshots:

Before:

Screenshot 2023-08-29 at 1.08.52 PM.png (1×958 px, 373 KB)

After:

Screenshot 2023-08-29 at 1.09.06 PM.png (1×958 px, 371 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu published this revision for review.Aug 29 2023, 10:14 AM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.

Can you use the SingleLine component?

This revision is now accepted and ready to land.Sep 6 2023, 2:00 PM