Paths

Table of Contentst

[native] Remove QRCodeLinkHandler from the codebase
AbandonedPublic
Actions

Authored by rohan on Aug 30 2023, 8:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 29, 10:47 PM

	Unknown Object (File)
	Thu, Jun 27, 12:50 AM

	Unknown Object (File)
	Tue, Jun 25, 10:35 AM

	Unknown Object (File)
	Thu, Jun 20, 9:30 PM

	Unknown Object (File)
	Wed, Jun 12, 12:20 AM

	Unknown Object (File)
	Fri, Jun 7, 1:15 AM

	Unknown Object (File)
	Thu, Jun 6, 10:17 AM

	Unknown Object (File)
	May 10 2024, 4:07 PM

View All 32 Files

Subscribers

ashoat

Details

Reviewers

tomek
atul
ginsu

Summary

QRCodeLinkHandler should now be redundant since we handle all QR code link handling in the new DeepLinksContextProvider, so we can delete the file and references to it

This is not part of a monthly goal, just a follow-up task.

Depends on D9028

Part of ENG-4810

Test Plan

Ran flow to make sure I didn't miss anything, and repeated the test plan from D9028

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Aug 30 2023, 8:55 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 30 2023, 8:55 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 30 2023, 8:57 AM

Harbormaster failed remote builds in B22272: Diff 30569!

rohan edited the summary of this revision. (Show Details)Aug 30 2023, 8:57 AM

rohan requested review of this revision.Aug 30 2023, 9:06 AM

tomek accepted this revision.Aug 31 2023, 4:42 AM

This revision is now accepted and ready to land.Aug 31 2023, 4:42 AM

Going to handle this in D9028

Revision Contents
Changeset List

Path

Size

native/

navigation/

navigation-handler.react.js

2 lines

qr-code-link-handler.react.js

Diff 30569

View Options

native/navigation/navigation-handler.react.js