[web] Fix wrong selector used to obtain connection
ClosedPublic
Actions

Authored by inka on Aug 31 2023, 6:05 AM.

Details

Reviewers

michal
kamil
tomek

Commits

rCOMM5a4d120b84bd: [web] Fix wrong selector used to obtain connection

Summary

issue: https://linear.app/comm/issue/ENG-4826/uncaught-typeerror-cannot-read-properties-of-undefined-reading-status
connection was moved to keyserverStore, so it should be fetched with connectionSelector. This was causing errors
useSelector from 'react-redux' was used instead the one from web/redux/redux-utils.js, so flow check did catch it before

Test Plan

checked that the error disappeared
reloaded the page
logged out and back in
checked other places where we use useSelector from 'react-redux' on lib, web and native to see if I didn't miss anything else

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Aug 31 2023, 6:05 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 31 2023, 6:05 AM

Harbormaster completed remote builds in B22310: Diff 30650.Aug 31 2023, 6:23 AM

inka requested review of this revision.Aug 31 2023, 6:23 AM

tomek accepted this revision.Aug 31 2023, 6:29 AM

tomek added inline comments.

web/push-notif/badge-handler.react.js
14–23 ↗	(On Diff #30650)	It might be a good idea to mention in this invariant that it's a connection for a keyserver with `ashoatKeyserverID`. It might be even better to avoid an invariant - how about accessing connection status optionally?