Page MenuHomePhabricator

[native] upgrade rn-emoji-keyboard to v1.5.1

Authored by ginsu on Tue, Sep 5, 9:15 AM.
Referenced Files
Unknown Object (File)
Wed, Sep 20, 10:27 PM
F743924: Screen Recording 2023-09-05 at 12.19.49
Tue, Sep 5, 9:20 AM
F743919: Screen Recording 2023-09-05 at 12.16.35
Tue, Sep 5, 9:19 AM



Our friends from rn-emoji-keyboard just released a new update to their emoji keyboard library which includes a fix for the bug mentioned in ENG-4277. This diff updates our usage of rn-emoji-keyboard to this latest version

Link to PR:

Test Plan

Check out the demo video to see that keyboard is no longer blocking the bottom emojis when the keyboard is open

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat, kamil.
ginsu edited the test plan for this revision. (Show Details)

Made @ashoat blocking since this a dependency diff

ginsu requested review of this revision.Tue, Sep 5, 9:33 AM

Seems fine at a glance

This revision is now accepted and ready to land.Wed, Sep 6, 6:12 PM