Page MenuHomePhabricator

[native] upgrade rn-emoji-keyboard to v1.5.1
ClosedPublic

Authored by ginsu on Sep 5 2023, 9:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 16, 6:44 AM
Unknown Object (File)
Tue, Jul 16, 6:44 AM
Unknown Object (File)
Tue, Jul 16, 6:44 AM
Unknown Object (File)
Tue, Jul 16, 6:41 AM
Unknown Object (File)
Tue, Jun 25, 7:12 PM
Unknown Object (File)
Tue, Jun 25, 11:58 AM
Unknown Object (File)
Jun 22 2024, 9:35 AM
Unknown Object (File)
Jun 21 2024, 3:23 AM
Subscribers

Details

Summary

Our friends from rn-emoji-keyboard just released a new update to their emoji keyboard library which includes a fix for the bug mentioned in ENG-4277. This diff updates our usage of rn-emoji-keyboard to this latest version

Link to PR: https://github.com/TheWidlarzGroup/rn-emoji-keyboard/pull/149

Test Plan

Check out the demo video to see that keyboard is no longer blocking the bottom emojis when the keyboard is open

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat, kamil.
ginsu edited the test plan for this revision. (Show Details)

Made @ashoat blocking since this a dependency diff

ginsu requested review of this revision.Sep 5 2023, 9:33 AM

Seems fine at a glance

This revision is now accepted and ready to land.Sep 6 2023, 6:12 PM