Page MenuHomePhabricator

[web] remove glow effect for the message action tooltip
ClosedPublic

Authored by ginsu on Sep 5 2023, 10:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 15, 5:09 PM
Unknown Object (File)
Mon, Jul 15, 5:09 PM
Unknown Object (File)
Mon, Jul 15, 5:09 PM
Unknown Object (File)
Mon, Jul 15, 5:09 PM
Unknown Object (File)
Mon, Jul 15, 5:05 PM
Unknown Object (File)
Sun, Jul 7, 6:30 PM
Unknown Object (File)
Sat, Jul 6, 10:27 AM
Unknown Object (File)
Thu, Jul 4, 7:46 PM

Details

Summary
Test Plan

Please see the before and after screenshots, also confirmed with @ted IRL and we both think this is an improvement visually

Before:

Screenshot 2023-09-05 at 1.30.32 PM.png (320×672 px, 39 KB)

After:

Screenshot 2023-09-05 at 1.31.03 PM.png (278×462 px, 18 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Sep 5 2023, 10:52 AM

Personally would prefer if in this same diff we opted for some sort of outline or shadow or anything to preserve the "depth" effect that the glow was supposed to provide

This revision is now accepted and ready to land.Sep 6 2023, 2:01 PM

Personally would prefer if in this same diff we opted for some sort of outline or shadow or anything to preserve the "depth" effect that the glow was supposed to provide

Going to land this now as is so that the message action tooltip can match how the reaction tooltip looks; however, I created this linear task for @ted to design this "depth" effect into the tooltips and will put up a follow up diff after that is done.

https://linear.app/comm/issue/DES-141/design-depth-effect-for-web-tooltips