Save encrypted payload hash in MariaDB keyserver for iOS notifs.
ClosedPublic
Actions

Authored by marcin on Wed, Sep 13, 6:52 AM.

Details

Reviewers

kamil
varun
ashoat

Commits

rCOMM2c5c658b3434: Save encrypted payload hash in MariaDB keyserver for iOS notifs.

Summary

This differential saves encrypted payload hash for each encrypted iOS notification in MariaDB. Combined with the parent differential this differential enables us to check if there is a match between the hash of notification delivered to iOS device and notification sent from the keyserver.

Test Plan

Build iOS app.
Send notification.
Check in MariaDB that there is an entry with delivery that contains non-empty array of sha 256 hashes.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Wed, Sep 13, 6:52 AM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Sep 13, 6:52 AM

marcin added a parent revision: D9178: Enhance error check in CryptoModule decrypt. Add encrypted message hash to error message..Wed, Sep 13, 6:54 AM

marcin edited the summary of this revision. (Show Details)Wed, Sep 13, 7:03 AM

marcin edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B22586: Diff 31044.Wed, Sep 13, 7:09 AM

marcin requested review of this revision.Wed, Sep 13, 7:09 AM

ashoat added inline comments.Wed, Sep 13, 7:20 AM

keyserver/src/push/send.js
1052–1059 ↗	(On Diff #31044)	It's good to always improve types when you touch them. Can this object be made read-only?
1105 ↗	(On Diff #31044)	How will we know which encrypted payload hash corresponds to which device? What do you think of having an object pointing from `deviceToken` to the payload hash?