Page MenuHomePhabricator

Save encrypted payload hash in MariaDB keyserver for iOS notifs.

Authored by marcin on Wed, Sep 13, 6:52 AM.
Referenced Files
F774605: D9179.id31178.diff
Tue, Sep 26, 9:33 AM
F774215: D9179.id31044.diff
Mon, Sep 25, 11:50 PM
Unknown Object (File)
Mon, Sep 25, 5:39 AM
Unknown Object (File)
Sun, Sep 24, 10:25 PM
Unknown Object (File)
Tue, Sep 19, 11:50 AM



This differential saves encrypted payload hash for each encrypted iOS notification in MariaDB. Combined with the parent differential this differential enables us to check if there is a match between the hash of notification delivered to iOS device and notification sent from the keyserver.

Test Plan
  1. Build iOS app.
  2. Send notification.
  3. Check in MariaDB that there is an entry with delivery that contains non-empty array of sha 256 hashes.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

marcin edited the test plan for this revision. (Show Details)
1052–1059 ↗(On Diff #31044)

It's good to always improve types when you touch them. Can this object be made read-only?

1105 ↗(On Diff #31044)

How will we know which encrypted payload hash corresponds to which device? What do you think of having an object pointing from deviceToken to the payload hash?

Accepting since my comments are minor, but if you disagree feel free to re-request review

This revision is now accepted and ready to land.Wed, Sep 13, 10:05 AM
  1. Update typing
  2. Save device token to hash mapping instead of plain hash list.