Page MenuHomePhabricator

[keyserver] Skip early exit in deleteThread if ignorePermissions
ClosedPublic

Authored by ashoat on Sep 19 2023, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Mon, Oct 28, 8:40 PM
Unknown Object (File)
Sat, Oct 12, 4:07 PM
Unknown Object (File)
Oct 1 2024, 6:00 PM
Unknown Object (File)
Oct 1 2024, 6:00 PM
Unknown Object (File)
Oct 1 2024, 5:58 PM
Unknown Object (File)
Sep 10 2024, 12:07 PM
Subscribers

Details

Summary

When I ran the migration in D9230 on production, it succeeded but didn't delete the threads. After some testing I realized there was an error in D9229, which didn't come up in my testing because I was testing in a community that commbot happened to be part of in my local environment.

The issue is that the "early exit" here will trigger if there is no permissions blob. In the case of ignorePermissions, we want the operation to go through even if there is no permissions blob for the script viewer's user (commbot).

Test Plan

I applied this patch in production, and then re-ran the migration. The bad threads were finally deleted

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable