Page MenuHomePhabricator

[keyserver] Add ignorePermissions option to deleteThread
ClosedPublic

Authored by ashoat on Sep 19 2023, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 17, 5:48 PM
Unknown Object (File)
Wed, Jul 17, 4:41 PM
Unknown Object (File)
Wed, Jul 17, 2:58 PM
Unknown Object (File)
Wed, Jul 17, 1:12 PM
Unknown Object (File)
Wed, Jul 17, 5:19 AM
Unknown Object (File)
Fri, Jun 28, 7:02 PM
Unknown Object (File)
Jun 18 2024, 6:37 AM
Unknown Object (File)
Jun 18 2024, 6:37 AM
Subscribers

Details

Summary

This is needed in the following diff so that we can call deleteThread from a migrations context, where we use a viewer that otherwise doesn't have permissions to delete any thread (createScriptViewer(bots.commbot.userID)).

I modeled it after the equivalent permission in updateThread.

Test Plan

Before this diff, the following diff errored with an invalid_credentials error. After this diff, it no longer does.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat published this revision for review.Sep 19 2023, 1:31 PM
This revision is now accepted and ready to land.Sep 19 2023, 1:35 PM