Page MenuHomePhabricator

[keyserver] Prevent creation of sidebars from pinned message robotext
ClosedPublic

Authored by ashoat on Sep 19 2023, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 18, 6:37 AM
Unknown Object (File)
Tue, Jun 18, 6:37 AM
Unknown Object (File)
Tue, Jun 18, 6:37 AM
Unknown Object (File)
Tue, Jun 18, 6:37 AM
Unknown Object (File)
Tue, Jun 18, 6:35 AM
Unknown Object (File)
Fri, Jun 14, 1:57 PM
Unknown Object (File)
Fri, Jun 14, 12:44 AM
Unknown Object (File)
May 16 2024, 7:49 AM
Subscribers

Details

Summary

These sidebars are causing our keyserver to completely crash and the app to break (ENG-4849). This diff prevents the creation of such sidebars on the keyserver. Preventing the sidebar creation button from appearing in the UI on native and web will be handled separately.

Depends on D9231

Test Plan

Try creating a sidebar from a pinned message in my local environment and confirm that it now errors out

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat published this revision for review.Sep 19 2023, 1:32 PM
This revision is now accepted and ready to land.Sep 19 2023, 1:40 PM

Also prevent sidebar creation from a CHANGE_ROLE robotext. Context is in ENG-4981... this change won't solve the issue (since the client app crashes in the pending sidebar, before the sidebar creation can even go through) but it's probably a good idea

This revision was landed with ongoing or failed builds.Sep 19 2023, 1:42 PM
This revision was automatically updated to reflect the committed changes.