[keyserver] Prevent creation of sidebars from pinned message robotext
ClosedPublic
Actions

Authored by ashoat on Sep 19 2023, 1:24 PM.

Details

Reviewers

atul
rohan
inka

Commits

rCOMM01bf7ede77a3: [keyserver] Prevent creation of sidebars from pinned message robotext

Summary

These sidebars are causing our keyserver to completely crash and the app to break (ENG-4849). This diff prevents the creation of such sidebars on the keyserver. Preventing the sidebar creation button from appearing in the UI on native and web will be handled separately.

Depends on D9231

Test Plan

Try creating a sidebar from a pinned message in my local environment and confirm that it now errors out

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 19 2023, 1:24 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 19 2023, 1:24 PM

ashoat published this revision for review.Sep 19 2023, 1:32 PM

atul accepted this revision.Sep 19 2023, 1:40 PM

This revision is now accepted and ready to land.Sep 19 2023, 1:40 PM

Also prevent sidebar creation from a CHANGE_ROLE robotext. Context is in ENG-4981... this change won't solve the issue (since the client app crashes in the pending sidebar, before the sidebar creation can even go through) but it's probably a good idea

This revision was landed with ongoing or failed builds.Sep 19 2023, 1:42 PM

Closed by commit rCOMM01bf7ede77a3: [keyserver] Prevent creation of sidebars from pinned message robotext (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM01bf7ede77a3: [keyserver] Prevent creation of sidebars from pinned message robotext.

Harbormaster completed remote builds in B22740: Diff 31278.Sep 19 2023, 1:43 PM

Harbormaster completed remote builds in B22742: Diff 31280.Sep 19 2023, 1:59 PM