[native] helper functions for resolving JS promises with void
ClosedPublic
Actions

Authored by varun on Sep 22 2023, 1:03 PM.

Details

Reviewers

kamil
bartek

Commits

rCOMM6a8c6944f897: [native] helper functions for resolving JS promises with void

Summary

we currently only support resolving Promise<string>. This lets us handle Promise<void> too.

Test Plan

called the new helper function as part of the update_password workflow and it worked as expected

Diff Detail

Repository

rCOMM Comm

Branch

native-client

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Sep 22 2023, 1:03 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 22 2023, 1:03 PM

forgot a file

Harbormaster completed remote builds in B22804: Diff 31374.Sep 22 2023, 1:22 PM

Harbormaster completed remote builds in B22805: Diff 31375.

varun requested review of this revision.Sep 22 2023, 1:23 PM

kamil accepted this revision.Sep 25 2023, 1:52 AM

This revision is now accepted and ready to land.Sep 25 2023, 1:52 AM

simplify logic

This revision was landed with ongoing or failed builds.Sep 25 2023, 12:41 PM

Closed by commit rCOMM6a8c6944f897: [native] helper functions for resolving JS promises with void (authored by varun). · Explain Why

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM6a8c6944f897: [native] helper functions for resolving JS promises with void.

Harbormaster completed remote builds in B22839: Diff 31411.Sep 25 2023, 12:47 PM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

InternalModules/

RustPromiseManager.cpp

15 lines

native_rust_library/

RustCallback.h

1 line

RustCallback.cpp

14 lines

Diff 31375

View Options

native/cpp/CommonCpp/NativeModules/InternalModules/RustPromiseManager.cpp

View Options

native/native_rust_library/RustCallback.h

View Options

native/native_rust_library/RustCallback.cpp

[native] helper functions for resolving JS promises with voidClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31375

native/cpp/CommonCpp/NativeModules/InternalModules/RustPromiseManager.cpp

native/native_rust_library/RustCallback.h

native/native_rust_library/RustCallback.cpp

[native] helper functions for resolving JS promises with void
ClosedPublic
Actions

Revision Contents
Changeset List