[keyserver] Fix threadFetchMediaResponder output validation
ClosedPublic
Actions

Authored by ashoat on Sep 26 2023, 8:53 PM.

Details

Reviewers

atul
rohan
michal
bartek

Commits

rCOMMdd8e90e0a43d: [keyserver] Fix threadFetchMediaResponder output validation

Summary

This addresses ENG-5053.

We're returning a Number when the output validator (and the Flow types) expect a String.

Test Plan

Before this diff, the output validator was failing in my local environment. After this diff it no longer failed.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 26 2023, 8:53 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 26 2023, 8:53 PM

ashoat published this revision for review.Sep 26 2023, 8:55 PM

atul accepted this revision.Sep 26 2023, 9:01 PM

This revision is now accepted and ready to land.Sep 26 2023, 9:01 PM

This revision was landed with ongoing or failed builds.Sep 26 2023, 9:02 PM

Closed by commit rCOMMdd8e90e0a43d: [keyserver] Fix threadFetchMediaResponder output validation. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMdd8e90e0a43d: [keyserver] Fix threadFetchMediaResponder output validation.

Harbormaster completed remote builds in B22852: Diff 31433.Sep 26 2023, 9:13 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

upload-fetchers.js

3 lines

Diff 31435

View Options

keyserver/src/fetchers/upload-fetchers.js

[keyserver] Fix threadFetchMediaResponder output validationClosedPublicActions