Page MenuHomePhabricator

[keyserver/lib] Move isInvalidSidebarSource from message-utils to message-types
AbandonedPublic

Authored by rohan on Sep 28 2023, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:37 PM
Unknown Object (File)
Wed, Nov 20, 4:18 PM
Unknown Object (File)
Thu, Nov 14, 7:39 PM
Unknown Object (File)
Thu, Nov 14, 5:17 PM
Unknown Object (File)
Fri, Nov 8, 9:25 PM
Unknown Object (File)
Mon, Oct 28, 9:43 AM
Unknown Object (File)
Oct 19 2024, 4:19 AM

Details

Reviewers
atul
ginsu
Summary

Just a simple moving diff since it makes more sense to be with message types in my opinion rather than message utils.

Depends on D9322

Test Plan

Ran flow and manually checked the imports were updated

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 28 2023, 12:44 PM
Harbormaster failed remote builds in B22904: Diff 31535!
rohan requested review of this revision.Sep 28 2023, 1:34 PM

I'll rerun CI when it's back up, requesting review in the meantime

This revision is now accepted and ready to land.Sep 29 2023, 12:07 PM
rohan added a subscriber: michal.

@michal pointed out that doing this will later cause a circular dependency, so I'm keeping it in message-utils