[native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo
ClosedPublic
Actions

Authored by ashoat on Sep 29 2023, 11:52 AM.

Details

Reviewers

atul
rohan
michal

Commits

rCOMM5bb5a97953f3: [native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo

Summary

After working on D9332, I looked around for other cases where we were passing a ThreadInfo to threadMembersWithoutAddedAshoat, since that is a no-op. I found one other such case, so I decided to remove it.

Depends on D9332

Test Plan

Careful reading and Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 29 2023, 11:52 AM

Herald added a subscriber: tomek. · View Herald TranscriptSep 29 2023, 11:52 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 29 2023, 12:02 PM

Harbormaster failed remote builds in B22923: Diff 31557!

Fix check

Harbormaster completed remote builds in B22926: Diff 31564.Sep 29 2023, 12:36 PM

ashoat requested review of this revision.Sep 29 2023, 12:36 PM

atul accepted this revision.Sep 29 2023, 1:12 PM

This revision is now accepted and ready to land.Sep 29 2023, 1:12 PM

Closed by commit rCOMM5bb5a97953f3: [native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo (authored by ashoat). · Explain WhySep 29 2023, 2:07 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5bb5a97953f3: [native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat.react.js

8 lines

Diff 31578

View Options

native/chat/chat.react.js

Show All 10 Lines
div.messageActionContainer {		div.messageActionContainer {
display: flex;		display: flex;
flex-direction: row;		flex-direction: row;
align-items: center;		align-items: center;
justify-content: center;		justify-content: center;
background-color: var(--message-action-tooltip-bg);		background-color: var(--message-action-tooltip-bg);
border-radius: 8px;		border-radius: 8px;
width: fit-content;		width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
}		}

div.messageActionButtons {		div.messageActionButtons {
display: flex;		display: flex;
font-size: 16px;		font-size: 16px;
}		}
div.messageActionButtons svg {		div.messageActionButtons svg {
padding: 10px 6px 6px;		padding: 10px 6px 6px;
Show All 17 Lines	div.messageTooltipLabel {
flex-direction: row;		flex-direction: row;
align-items: center;		align-items: center;
justify-content: center;		justify-content: center;
background-color: var(--message-action-tooltip-bg);		background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color);		color: var(--tool-tip-color);
border-radius: 8px;		border-radius: 8px;
overflow: auto;		overflow: auto;
white-space: nowrap;		white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
}		}

div.leftTooltipAlign {		div.leftTooltipAlign {
align-items: flex-start;		align-items: flex-start;
}		}

div.centerTooltipAlign {		div.centerTooltipAlign {
align-items: center;		align-items: center;
Show All 10 Lines

[native] Remove threadMembersWithoutAddedAshoat check for ThreadInfoClosedPublicActions