Previously for each notification received by backgrounded app we sent separate JS event so that it could be persisted in redux and SQLite. However there was
no reason not to send one JS event with array of all messages. It can potentially help the issue:
https://linear.app/comm/issue/ENG-5147/messageinfos-from-notifs-take-too-long-to-import-on-ios-start#comment-a2fb0774
Details
Details
- Build iOS app.
- Background it.
- Send multiple messages.
- Kill the keyserver.
- Bring the app to the foreground again.
- Ensure all messages are available in the relevant thread(s) even the keyserver is not running.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good to me but letting others review as well
native/push/push-handler.react.js | ||
---|---|---|
548–550 ↗ | (On Diff #31812) | This should also work |
native/push/ios.js | ||
---|---|---|
85 ↗ | (On Diff #31812) | Is it really optional? |