Page MenuHomePhabricator
Differential D9450

[keyserver] rename `retrieveAccountKeysSet` -> `retrieveSessionInitializationKeysSet`
ClosedPublic
Actions

Authored by kamil on Oct 11 2023, 6:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 25, 10:55 PM
Unknown Object (File)
Sun, Mar 16, 11:14 PM
Unknown Object (File)
Mar 8 2025, 7:07 AM
Unknown Object (File)
Mar 8 2025, 7:07 AM
Unknown Object (File)
Mar 8 2025, 7:07 AM
Unknown Object (File)
Mar 8 2025, 6:59 AM
Unknown Object (File)
Feb 21 2025, 10:28 AM
Unknown Object (File)
Jan 20 2025, 7:12 AM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
marcin
Commits
rCOMM38818ef31dfe: [keyserver] rename `retrieveAccountKeysSet` ->…
Summary

Addresses: https://phab.comm.dev/D9422#276975

We get to the point where there are two functions with the same name, but doing different things. This should make it more consistent to avoid confusion.

Depends on D9427

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Oct 11 2023, 6:09 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 11 2023, 6:10 AM
kamil mentioned this in D9422: [keyserver] delete marking prekeys as published each time `olm` account is accessed.Oct 11 2023, 6:11 AM
kamil added inline comments.
keyserver/src/responders/keys-responders.js
56 ↗(On Diff #31928)

unifying error codes for the same issue: link

Harbormaster completed remote builds in B23184: Diff 31928.Oct 11 2023, 6:26 AM
kamil requested review of this revision.Oct 11 2023, 6:26 AM
marcin added inline comments.Oct 12 2023, 2:33 AM
keyserver/src/responders/keys-responders.js
56 ↗(On Diff #31928)

The fact that prekey_signature() method is typed as ?string is not actually correct. If you take a look at the code: https://github.com/CommE2E/olm/blob/main/src/account.cpp it appears that prekey signature is always there as long as there is a prekey. I think it is a relict from the period when prekey() indeed could return undefined. We later decided that prekey will always be generated so we updated prekey() typing but we probably forgot to update prekey_signature() typing.

marcin accepted this revision.Oct 12 2023, 2:34 AM
This revision is now accepted and ready to land.Oct 12 2023, 2:34 AM
kamil added inline comments.Oct 16 2023, 1:46 AM
keyserver/src/responders/keys-responders.js
56 ↗(On Diff #31928)

ENG-5255

Closed by commit rCOMM38818ef31dfe: [keyserver] rename `retrieveAccountKeysSet` ->… (authored by kamil). · Explain WhyOct 16 2023, 2:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM38818ef31dfe: [keyserver] rename `retrieveAccountKeysSet` ->….

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
15 lines

Diff 32032

View Options

keyserver/src/responders/keys-responders.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines