[keyserver] rename `retrieveAccountKeysSet` -> `retrieveSessionInitializationKeysSet`
ClosedPublic
Actions

Authored by kamil on Oct 11 2023, 6:09 AM.

Details

Reviewers

marcin

Commits

rCOMM38818ef31dfe: [keyserver] rename `retrieveAccountKeysSet` ->…

Summary

Addresses: https://phab.comm.dev/D9422#276975

We get to the point where there are two functions with the same name, but doing different things. This should make it more consistent to avoid confusion.

Depends on D9427

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 11 2023, 6:09 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 11 2023, 6:10 AM

kamil mentioned this in D9422: [keyserver] delete marking prekeys as published each time `olm` account is accessed.Oct 11 2023, 6:11 AM

kamil added inline comments.

keyserver/src/responders/keys-responders.js
56 ↗	(On Diff #31928)	unifying error codes for the same issue: link

Harbormaster completed remote builds in B23184: Diff 31928.Oct 11 2023, 6:26 AM

kamil requested review of this revision.Oct 11 2023, 6:26 AM

marcin added inline comments.Oct 12 2023, 2:33 AM

keyserver/src/responders/keys-responders.js
56 ↗	(On Diff #31928)	The fact that `prekey_signature()` method is typed as `?string` is not actually correct. If you take a look at the code: https://github.com/CommE2E/olm/blob/main/src/account.cpp it appears that prekey signature is always there as long as there is a prekey. I think it is a relict from the period when `prekey()` indeed could return `undefined`. We later decided that `prekey` will always be generated so we updated `prekey()` typing but we probably forgot to update `prekey_signature()` typing.