Paths

Table of Contentst

[CI] Clear unused NDKs from Android GitHub CI jobs before proceeding
ClosedPublic
Actions

Authored by ashoat on Oct 12 2023, 5:28 AM.

Details

Reviewers

atul
bartek

Commits

rCOMMcb654030b973: [CI] Clear unused NDKs from Android GitHub CI jobs before proceeding

Summary

I was able to SSH into a GitHub runner using tmate. After playing around a bit, I realized a bunch of time and disk space was spent installing the Android NDK.

React Native 0.70 uses uses an ancient version of the Android NDK (21.4.7075529) that is no longer preinstalled on GitHub runner images. As a result, the Gradle build has to install that Android NDK. During installation a large amount of disk space is used (about 5 GB or so), which is later partially freed after the installation succeeds.

In fact the GitHub runner comes with 4 NDKs preinstalled. They take up a lot of disk space. This diff deletes the NDKs that we don't use. (Actually it keeps 24 around because React Native 0.70 mentions two NDKs... 24 for Apple silicon and ancient 21 for the rest.)

Worth noting that React Native 0.71 and 0.72 move to using NDK 23 (for both Apple silicon and other), and 0.73 moves to NDK 25 (fairly recent). As a result we hopefully won't need to download an NDK during GitHub CI build in the future.

Test Plan

I forked the Comm repo, added the necessary GitHub secrets, and enabled GitHub Actions on the fork. I was able to test this diff on the work and confirm that it worked to fix the Android CI build (4.3 GB free at the end of the build). I haven't tested the release action, but I suspect it's relatively similar.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 12 2023, 5:28 AM

Herald added subscribers: will, tomek. · View Herald TranscriptOct 12 2023, 5:28 AM

ashoat added inline comments.Oct 12 2023, 5:36 AM

.github/workflows/android_ci.yml
28 ↗	(On Diff #31962)	From my research, `$ANDROID_NDK_HOME` was deprecated at some point in favor of using `$ANDROID_SDK_ROOT/ndk`
29 ↗	(On Diff #31962)	I personally find `awk` a bit more sensible for this use case than `bash`, so I wrote it using `awk`. I'm open to rewriting if people feel strongly. The opening curly braces here tell `awk` to do the things inside the curly braces for each line that it gets.
30 ↗	(On Diff #31962)	Some pointers here: Whitespace does concatentation in `awk` `$0` is the whole individual input line in `awk` `system` returns the exit code of the program it runs `git grep` returns 0 for success, or 1 if it doesn't find anything `> /dev/null` silences output, which otherwise `awk` prints to the screen
31 ↗	(On Diff #31962)	I close and reopen the single-string quotation here so I can access a bash variable. I also double-quote the bash variable invocation, which is considered good practice in bash

Harbormaster completed remote builds in B23210: Diff 31962.Oct 12 2023, 5:46 AM

ashoat requested review of this revision.Oct 12 2023, 5:46 AM

Thanks for explaining, I think using awk is reasonable/practical in this limited use case.

FWIW, popped it into ChatGPT to ask for equivalent one-liners and it came up with:

find "$ANDROID_SDK_ROOT/ndk" -type d -exec sh -c 'git grep -qs "$1" || rm -rf "$1"' _ {} \;

This revision is now accepted and ready to land.Oct 12 2023, 6:36 AM

Yeahhhh I considered that sort of approach but I personally find it less readable with all the special characters at the end

Closed by commit rCOMMcb654030b973: [CI] Clear unused NDKs from Android GitHub CI jobs before proceeding (authored by ashoat). · Explain WhyOct 12 2023, 6:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcb654030b973: [CI] Clear unused NDKs from Android GitHub CI jobs before proceeding.

ashoat mentioned this in D13247: [GitHub CI] Clear unused NDKs and iOS simulator to fix Android CI.Sep 5 2024, 9:17 AM

ashoat mentioned this in rCOMM3e5b8b08e401: [GitHub CI] Clear unused NDKs and iOS simulator to fix Android CI.Sep 5 2024, 9:22 AM

Revision Contents
Changeset List

Path

Size

.github/

workflows/

android_ci.yml

9 lines

android_release.yml

9 lines

Diff 31963

View Options

.github/workflows/android_ci.yml