Differential D9490
[web] Add protoc-gen-js dependency Authored by ashoat on Oct 13 2023, 12:58 PM. Tags None Referenced Files
Details
This is an addon to protoc that is necessary in order to run the script in the next diff. It's not usually packaged as an NPM package - context here. The protoc in my local install has this addon already, which is why I didn't seem to need this change in my previous work in D7306. But the protoc in Nix doesn't seem to have this for some reason. We could probably bring this in via Nix instead. I'm open to that if people prefer. Without this diff, the script in the following diff fails with the following error: yarn run v1.22.19 $ ./scripts/codegen-identity-grpc.sh protoc-gen-js: program not found or is not executable Please specify a program using absolute path or make sure the program is available in your PATH system variable --js_out: protoc-gen-js: Plugin failed with status code 1. error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. After introducing the protoc-gen-js dependency, the script no longer errors.
Diff Detail
Event TimelineComment Actions I'd prefer to bring this in through Nix. if we need to upgrade protoc + protoc-gen-js in the future, it'll be easier if they're in the same place Comment Actions I checked nixpkgs and I couldn't find protoc-gen-js in the repo:  I also searched for protobuf-javascript, which is where protoc-gen-js is supposed to be packaged based on the NPM package description, but couldn't find that either. The closest I could find is this pull request for protoc-gen-es, which seems to be an alternate implementation. The PR has not been merged yet. |