Page MenuHomePhabricator
Differential D9516

[web] fix width of user profile action button
ClosedPublic
Actions

Authored by ginsu on Oct 17 2023, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 11:52 AM
Unknown Object (File)
Wed, Oct 2, 11:52 AM
Unknown Object (File)
Wed, Oct 2, 11:52 AM
Unknown Object (File)
Wed, Oct 2, 11:48 AM
Unknown Object (File)
Wed, Oct 2, 6:01 AM
Unknown Object (File)
Wed, Sep 18, 6:23 AM
Unknown Object (File)
Tue, Sep 17, 10:50 PM
Unknown Object (File)
Aug 25 2024, 12:15 PM
View All 51 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM3c5948b45e0e: Revert "[lib/native] lift theme types from native into lib"
rCOMM548660d3f40c: [web] fix width of user profile action button
Summary

Just noticed that there was a minor regression with the user profile action buttons width. This diff address that regression

Test Plan

Please see screenshots below

before:

Screenshot 2023-10-17 at 3.51.27 PM.png (2×3 px, 743 KB)

after:

Screenshot 2023-10-17 at 3.51.32 PM.png (2×3 px, 743 KB)

confirmed that all the buttons for every relationship condition still looks/behaves the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 17 2023, 12:49 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 17 2023, 12:49 PM
ginsu published this revision for review.Oct 17 2023, 12:53 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F821588: Screenshot 2023-10-17 at 3.51.32 PM.png. (Show Details)
ginsu attached a referenced file: F821587: Screenshot 2023-10-17 at 3.51.27 PM.png. (Show Details)
Harbormaster completed remote builds in B23309: Diff 32104.Oct 17 2023, 1:07 PM
atul accepted this revision.Oct 17 2023, 2:19 PM

Thanks for addressing feedback

This revision is now accepted and ready to land.Oct 17 2023, 2:19 PM
ginsu updated this revision to Diff 32112.Oct 17 2023, 2:29 PM

rebase before landing

Harbormaster completed remote builds in B23317: Diff 32112.Oct 17 2023, 2:48 PM
Closed by commit rCOMM548660d3f40c: [web] fix width of user profile action button (authored by ginsu). · Explain WhyOct 17 2023, 2:53 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM548660d3f40c: [web] fix width of user profile action button.
ginsu added a commit: rCOMM3c5948b45e0e: Revert "[lib/native] lift theme types from native into lib".Oct 17 2023, 6:57 PM

Revision Contents
Changeset List

PathSize
web/
modals/
user-profile/
1 line

Diff 32126

View Options

web/modals/user-profile/user-profile.css

Loading...