Paths

Table of Contentst

[lib] Drill allAtOnce from useChatMentionCandidatesObjAndUtils to useENSNames
ClosedPublic
Actions

Authored by ashoat on Oct 18 2023, 7:11 PM.

Details

Reviewers

tomek
atul

Commits

rCOMMd6e7e669440d: [lib] Drill allAtOnce from useChatMentionCandidatesObjAndUtils to useENSNames

Summary

This solves ENG-5274. Additional context about allAtOnce in D9515.

Depends on D9466

Test Plan

I compared performance of the following two scenarios:

master + revert of D9465 + D9466
master + revert of D9465 + D9466 + this diff

While I did perceive a slight regression in TTI on the inbox by about a second, I think it's okay to land this stack (including @tomek's work) after this diff is accepted.

More details on next steps here.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 18 2023, 7:11 PM

Herald added a subscriber: will. · View Herald TranscriptOct 18 2023, 7:11 PM

Harbormaster completed remote builds in B23333: Diff 32152.Oct 18 2023, 7:30 PM

ashoat requested review of this revision.Oct 18 2023, 7:30 PM

atul accepted this revision.Oct 18 2023, 7:35 PM

This revision is now accepted and ready to land.Oct 18 2023, 7:35 PM

Closed by commit rCOMMd6e7e669440d: [lib] Drill allAtOnce from useChatMentionCandidatesObjAndUtils to useENSNames. · Explain WhyOct 19 2023, 12:20 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMd6e7e669440d: [lib] Drill allAtOnce from useChatMentionCandidatesObjAndUtils to useENSNames.

Revision Contents
Changeset List

Path

Size

lib/

components/

chat-mention-provider.react.js

11 lines

utils/

entity-helpers.js

16 lines

entity-text.js

9 lines

Diff 32152

View Options

lib/components/chat-mention-provider.react.js

View Options

lib/utils/entity-helpers.js

View Options

[lib] Drill allAtOnce from useChatMentionCandidatesObjAndUtils to useENSNamesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32152

lib/components/chat-mention-provider.react.js

lib/utils/entity-helpers.js

lib/utils/entity-text.js

[lib] Drill allAtOnce from useChatMentionCandidatesObjAndUtils to useENSNames
ClosedPublic
Actions

Revision Contents
Changeset List