Page MenuHomePhabricator

[lib] Drill allAtOnce from useChatMentionCandidatesObjAndUtils to useENSNames
ClosedPublic

Authored by ashoat on Oct 18 2023, 12:11 PM.
Tags
None
Referenced Files
F3373850: D9523.diff
Tue, Nov 26, 12:13 PM
Unknown Object (File)
Thu, Nov 14, 9:01 AM
Unknown Object (File)
Fri, Nov 1, 9:55 AM
Unknown Object (File)
Fri, Nov 1, 9:55 AM
Unknown Object (File)
Fri, Nov 1, 9:55 AM
Unknown Object (File)
Fri, Nov 1, 9:34 AM
Unknown Object (File)
Fri, Nov 1, 6:51 AM
Unknown Object (File)
Oct 18 2024, 9:03 PM
Subscribers

Details

Summary

This solves ENG-5274. Additional context about allAtOnce in D9515.

Depends on D9466

Test Plan

I compared performance of the following two scenarios:

  1. master + revert of D9465 + D9466
  2. master + revert of D9465 + D9466 + this diff

While I did perceive a slight regression in TTI on the inbox by about a second, I think it's okay to land this stack (including @tomek's work) after this diff is accepted.

More details on next steps here.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage