Page MenuHomePhabricator
Differential D9523

[lib] Drill allAtOnce from useChatMentionCandidatesObjAndUtils to useENSNames
ClosedPublic
Actions

Authored by ashoat on Oct 18 2023, 12:11 PM.
Tags
None
Referenced Files
F3243646: D9523.diff
Thu, Nov 14, 9:01 AM
Unknown Object (File)
Fri, Nov 1, 9:55 AM
Unknown Object (File)
Fri, Nov 1, 9:55 AM
Unknown Object (File)
Fri, Nov 1, 9:55 AM
Unknown Object (File)
Fri, Nov 1, 9:34 AM
Unknown Object (File)
Fri, Nov 1, 6:51 AM
Unknown Object (File)
Fri, Oct 18, 9:03 PM
Unknown Object (File)
Oct 6 2024, 12:44 AM
View All 71 Files
Subscribers
tomek
will

Details

Reviewers
tomek
atul
Commits
rCOMMd6e7e669440d: [lib] Drill allAtOnce from useChatMentionCandidatesObjAndUtils to useENSNames
Summary

This solves ENG-5274. Additional context about allAtOnce in D9515.

Depends on D9466

Test Plan

I compared performance of the following two scenarios:

  1. master + revert of D9465 + D9466
  2. master + revert of D9465 + D9466 + this diff

While I did perceive a slight regression in TTI on the inbox by about a second, I think it's okay to land this stack (including @tomek's work) after this diff is accepted.

More details on next steps here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
components/
11 lines
utils/
16 lines
9 lines

Diff 32193

View Options

lib/components/chat-mention-provider.react.js

Loading...
View Options

lib/utils/entity-helpers.js

Loading...
View Options

lib/utils/entity-text.js

Loading...