Page MenuHomePhabricator
Differential D9545

[web] Fix thread creation from media
ClosedPublic
Actions

Authored by ashoat on Oct 19 2023, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 5 2025, 1:31 AM
Unknown Object (File)
Feb 20 2025, 8:07 PM
Unknown Object (File)
Feb 2 2025, 12:16 PM
Unknown Object (File)
Jan 27 2025, 1:57 AM
Unknown Object (File)
Jan 24 2025, 9:20 AM
Unknown Object (File)
Jan 24 2025, 9:20 AM
Unknown Object (File)
Jan 24 2025, 9:20 AM
Unknown Object (File)
Jan 24 2025, 9:17 AM
View All Files
Subscribers
will

Details

Reviewers
bartek
atul
tomek
Commits
rCOMMea70657bd6b7: [web] Fix thread creation from media
Summary

This solves ENG-5145, a regression introduced in D7434.

The issue is that pending threads don't appear in the ThreadStore. Instead of trying to pull the ThreadInfo from the ThreadStore, we should drill it through from the callsites.

Test Plan

I confirmed that I'm again able to create a thread from media in my local environment (the bug no longer repros)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 32273

View Options

web/chat/chat-input-bar.react.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines
View Options

web/chat/chat-message-list-container.react.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines
View Options

web/input/input-state-container.react.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines
View Options

web/input/input-state.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines